Skip to contentSkip to conversation

s390: hypfs comment cleanup.

PATCH In review Martin Schwidefsky 2 participants 3 messages Aug 7, 2006

Subsystems (2)
s390 Driver core
lore
Share & tools
lore

Martin Schwidefsky

author
#0 lore raw

PATCH 1/1 s390: hypfs comment cleanup.

From: Michael Holzheu <[email protected]>

[S390] hypfs comment cleanup.

Correct some comments in the hypervisor filesystem.

Signed-off-by Michael Holzheu <[email protected]>
Signed-off-by Martin Schwidefsky <[email protected]>

---

 arch/s390/hypfs/hypfs.h      |    2 +-
 arch/s390/hypfs/hypfs_diag.c |    2 +-
 arch/s390/hypfs/hypfs_diag.h |    2 +-
 arch/s390/hypfs/inode.c      |    2 +-
 drivers/base/hypervisor.c    |    3 ++-
 5 files changed, 6 insertions(+), 5 deletions(-)
arch/s390/hypfs/hypfs_diag.c +1 -1
diff -urpN linux-2.6/arch/s390/hypfs/hypfs_diag.c linux-2.6-patched/arch/s390/hypfs/hypfs_diag.c
@@ -1,5 +1,5 @@
 /*
- *  fs/hypfs/hypfs_diag.c
+ *  arch/s390/hypfs/hypfs_diag.c
  *    Hypervisor filesystem for Linux on s390. Diag 204 and 224
  *    implementation.
  *
arch/s390/hypfs/hypfs_diag.h +1 -1
diff -urpN linux-2.6/arch/s390/hypfs/hypfs_diag.h linux-2.6-patched/arch/s390/hypfs/hypfs_diag.h
@@ -1,5 +1,5 @@
 /*
- *  fs/hypfs/hypfs_diag.h
+ *  arch/s390/hypfs_diag.h
  *    Hypervisor filesystem for Linux on s390.
  *
  *    Copyright (C) IBM Corp. 2006
arch/s390/hypfs/hypfs.h +1 -1
diff -urpN linux-2.6/arch/s390/hypfs/hypfs.h linux-2.6-patched/arch/s390/hypfs/hypfs.h
@@ -1,5 +1,5 @@
 /*
- *  fs/hypfs/hypfs.h
+ *  arch/s390/hypfs/hypfs.h
  *    Hypervisor filesystem for Linux on s390.
  *
  *    Copyright (C) IBM Corp. 2006
arch/s390/hypfs/inode.c +1 -1
diff -urpN linux-2.6/arch/s390/hypfs/inode.c linux-2.6-patched/arch/s390/hypfs/inode.c
@@ -1,5 +1,5 @@
 /*
- *  fs/hypfs/inode.c
+ *  arch/s390/hypfs/inode.c
  *    Hypervisor filesystem for Linux on s390.
  *
  *    Copyright (C) IBM Corp. 2006
drivers/base/hypervisor.c +2 -1
diff -urpN linux-2.6/drivers/base/hypervisor.c linux-2.6-patched/drivers/base/hypervisor.c
@@ -1,8 +1,9 @@
 /*
  * hypervisor.c - /sys/hypervisor subsystem.
  *
- * This file is released under the GPLv2
+ * Copyright (C) IBM Corp. 2006
  *
+ * This file is released under the GPLv2
  */
 
 #include <linux/kobject.h>
#1 lore raw
Quoted 1 line · Martin Schwidefsky

[S390] hypfs comment cleanup.

Please, just delete file lines as they carry no additional info.

Quoted 36 lines
arch/s390/hypfs/hypfs_diag.c +1 -1
@@ -1,5 +1,5 @@
 /*
- *  fs/hypfs/hypfs_diag.c
+ *  arch/s390/hypfs/hypfs_diag.c
  *    Hypervisor filesystem for Linux on s390. Diag 204 and 224
  *    implementation.
  *
arch/s390/hypfs/hypfs_diag.h +1 -1
@@ -1,5 +1,5 @@
 /*
- *  fs/hypfs/hypfs_diag.h
+ *  arch/s390/hypfs_diag.h
  *    Hypervisor filesystem for Linux on s390.
  *
  *    Copyright (C) IBM Corp. 2006
arch/s390/hypfs/hypfs.h +1 -1
@@ -1,5 +1,5 @@
 /*
- *  fs/hypfs/hypfs.h
+ *  arch/s390/hypfs/hypfs.h
  *    Hypervisor filesystem for Linux on s390.
  *
  *    Copyright (C) IBM Corp. 2006
arch/s390/hypfs/inode.c +1 -1
@@ -1,5 +1,5 @@
 /*
- *  fs/hypfs/inode.c
+ *  arch/s390/hypfs/inode.c
author
#2 lore raw
Quoted 4 lines · Alexey Dobriyan
Quoted 1 line · Martin Schwidefsky

[S390] hypfs comment cleanup.

Please, just delete file lines as they carry no additional info.

Hmm, it is common pratice to have the path of the source file in the comment. If we decide to remove all these path from the comments, this would be a perfect jobs for the kernel janitors. For now I want to keep things consistent with the majority of the files in arch/s390.

One thing in favor of having the path in the comment: if you print the file or copy it somewhere you still know where it came from. On the other hand who prints files from the linux source tree ?

Signature · 8 lines
blue skies,
  Martin.

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH

"Reality continues to ruin my life." - Calvin.