Skip to contentSkip to conversation

atyfb: Possible cleanups

PATCH New Antonino A. Daplas 1 participant 1 message Aug 21, 2006 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/5 atyfb: Possible cleanups

From: Adrian Bunk <[email protected]>

- make the following needlessly global function static:
- mach64_ct.c: aty_st_pll_ct()
- proper prototypes for the following functions:
- atyfb_base.c: atyfb_copyarea()
- atyfb_base.c: atyfb_fillrect()
- atyfb_base.c: atyfb_imageblit()

---

 drivers/video/aty/atyfb.h      |    6 +++++-
 drivers/video/aty/atyfb_base.c |    3 ---
 drivers/video/aty/mach64_ct.c  |    2 +-
 3 files changed, 6 insertions(+), 5 deletions(-)
drivers/video/aty/atyfb.h +5 -1
index 55fb8b0..b04f49f 100644
@@ -355,5 +355,9 @@ static inline void wait_for_idle(struct 
 
 extern void aty_reset_engine(const struct atyfb_par *par);
 extern void aty_init_engine(struct atyfb_par *par, struct fb_info *info);
-extern void aty_st_pll_ct(int offset, u8 val, const struct atyfb_par *par);
 extern u8   aty_ld_pll_ct(int offset, const struct atyfb_par *par);
+
+void atyfb_copyarea(struct fb_info *info, const struct fb_copyarea *area);
+void atyfb_fillrect(struct fb_info *info, const struct fb_fillrect *rect);
+void atyfb_imageblit(struct fb_info *info, const struct fb_image *image);
+
drivers/video/aty/atyfb_base.c +0 -3
index d6be4c7..f295005 100644
@@ -240,9 +240,6 @@ static int atyfb_setcolreg(u_int regno, 
 static int atyfb_pan_display(struct fb_var_screeninfo *var, struct fb_info *info);
 static int atyfb_blank(int blank, struct fb_info *info);
 static int atyfb_ioctl(struct fb_info *info, u_int cmd, u_long arg);
-extern void atyfb_fillrect(struct fb_info *info, const struct fb_fillrect *rect);
-extern void atyfb_copyarea(struct fb_info *info, const struct fb_copyarea *area);
-extern void atyfb_imageblit(struct fb_info *info, const struct fb_image *image);
 #ifdef __sparc__
 static int atyfb_mmap(struct fb_info *info, struct vm_area_struct *vma);
 #endif
drivers/video/aty/mach64_ct.c +1 -1
index e705693..5080816 100644
@@ -27,7 +27,7 @@ u8 aty_ld_pll_ct(int offset, const struc
 	return res;
 }
 
-void aty_st_pll_ct(int offset, u8 val, const struct atyfb_par *par)
+static void aty_st_pll_ct(int offset, u8 val, const struct atyfb_par *par)
 {
 	/* write addr byte */
 	aty_st_8(CLOCK_CNTL_ADDR, ((offset << 2) & PLL_ADDR) | PLL_WR_EN, par);

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642