mbxfb: Fix framebuffer size smaller than requested

PATCH New Antonino A. Daplas 1 participant 1 message Aug 21, 2006 Framebuffer layer

lore

Share & tools

lore

Antonino A. Daplas

author

2006-08-21 10:54 UTC #0 lore raw

PATCH 3/5 mbxfb: Fix framebuffer size smaller than requested

From: Raphael Assenat <[email protected]>

This patch fixes a bug where we obtain a smaller resolution than requested. (eg: in 640x480, only 639x479 usable pixels).

This was due to 1 being substracted from the xres and yres vars two times: first in mbxfb.c and then in the macros from reg_bits.h.

This patch removes the minus ones from the mbxfb.c file. Tested and works.

Signed-off-by Raphael Assenat <[email protected]>

Signed-off-by Antonino Daplas <[email protected]>

---

 drivers/video/mbx/mbxfb.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

drivers/video/mbx/mbxfb.c +4 -4

index cfc6bf3..a32d1af 100644
@@ -255,8 +255,8 @@ static int mbxfb_set_par(struct fb_info 
 
 	/* setup resolution */
 	gsctrl &= ~(FMsk(GSCTRL_GSWIDTH) | FMsk(GSCTRL_GSHEIGHT));
-	gsctrl |= Gsctrl_Width(info->var.xres - 1) |
-		Gsctrl_Height(info->var.yres - 1);
+	gsctrl |= Gsctrl_Width(info->var.xres) |
+		Gsctrl_Height(info->var.yres);
 	writel(gsctrl, GSCTRL);
 	udelay(1000);

@@ -413,8 +413,8 @@ static void __devinit setup_graphics(str
 {
 	unsigned long gsctrl;
 
-	gsctrl = GSCTRL_GAMMA_EN | Gsctrl_Width(fbi->var.xres - 1) |
-		Gsctrl_Height(fbi->var.yres - 1);
+	gsctrl = GSCTRL_GAMMA_EN | Gsctrl_Width(fbi->var.xres) |
+		Gsctrl_Height(fbi->var.yres);
 	switch (fbi->var.bits_per_pixel) {
 	case 16:
 		if (fbi->var.green.length == 5)

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642