Skip to contentSkip to conversation

vm_total_pages and page-writeback.c:total_pages

DISCUSSION Chandra Seetharaman 1 participant 1 message Aug 22, 2006 Memory management

lore
Share & tools
lore
#0 lore raw

Hello,

I was looking at page-writeback.c and found that there is a static variable "total_pages", which is same as the global variable "vm_total_pages" except that "total_pages" is not updated when new pages are brought in through memory hotplug.

Looking at the usage of "total_pages", it doesn't look intentional. Can somebody tell if it is the intentional or it a bug that needs to be fixed ?

Under the same context, "ratelimit_pages" in page-writeback.c is recalculated every time CPU is hot added/removed. But there is no recalculation happening when new memory pages are hot added. This also doesn't seem to be right. Comments ?

regards,

chandra

Signature · 11 lines
----------------------------------------------------------------------
    Chandra Seetharaman               | Be careful what you choose....
              - [email protected]   |      .......you may get it.
----------------------------------------------------------------------


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>