Skip to contentSkip to conversation

Move logs under /var/log/xen

PATCH In review Jeremy Katz 1 participant 2 messages Aug 18, 2006 – Aug 25, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Move logs under /var/log/xen

The attached patch moves all of the various log files created by xen to be under /var/log/xen instead of under /var/log directly. This has the advantage of cleaning things up a little[1] and also can make it easier to restrict the permissions needed by xend.

Jeremy

[1] This is especially true as you run HVM guests and the number of /var/log/qemu-dm.* files grows... :)

docs/man/xend-config.sxp.pod.5 +1 -1
diff -r ec03b24a2d83 docs/man/xend-config.sxp.pod.5
@@ -23,7 +23,7 @@ The following lists the daemon configura
 =item I<logfile>
 
 The location of the file to record runtime log messages.  Defaults to
-I</var/log/xend.log>.
+I</var/log/xen/xend.log>.
 
 =item I<loglevel>
 
docs/misc/xend.tex +2 -2
diff -r ec03b24a2d83 docs/misc/xend.tex
@@ -214,7 +214,7 @@ Configuration scripts ({\it e.g.} for ne
 Configuration scripts ({\it e.g.} for network-script) are looked for in {\tt /etc/xen}
 unless their name begins with '/'.
 
-Xend sends its log output to {\tt /var/log/xend.log}. This is a rotating logfile,
+Xend sends its log output to {\tt /var/log/xen/xend.log}. This is a rotating logfile,
 and logs are moved onto {\tt xend.log.1} {\it etc.} as they get large. Old logs may
 be deleted.
 
@@ -419,7 +419,7 @@ allows access to some debugging function
 \end{itemize}
 
 When tracing is on xend logs all functions calls and exceptions to
-{\tt /var/log/xend.trace}.
+{\tt /var/log/xen/xend.trace}.
 
 \begin{thebibliography}{99}
 
docs/src/user.tex +2 -2
diff -r ec03b24a2d83 docs/src/user.tex
@@ -973,8 +973,8 @@ using the \texttt{xm} tool.
 
 \subsection{Logging}
 
-As \xend\ runs, events will be logged to \path{/var/log/xend.log} and
-(less frequently) to \path{/var/log/xend-debug.log}. These, along with
+As \xend\ runs, events will be logged to \path{/var/log/xen/xend.log} and
+(less frequently) to \path{/var/log/xen/xend-debug.log}. These, along with
 the standard syslog files, are useful when troubleshooting problems.
 
 \subsection{Configuring \Xend\ }
tools/Makefile +1 -0
diff -r ec03b24a2d83 tools/Makefile
@@ -39,6 +39,7 @@ install: check
 	done
 	$(MAKE) ioemuinstall
 	$(INSTALL_DIR) -p $(DESTDIR)/var/xen/dump
+	$(INSTALL_DIR) -p $(DESTDIR)/var/log/xen
 
 .PHONY: clean
 clean: check_clean
tools/examples/xen-hotplug-common.sh +1 -1
diff -r ec03b24a2d83 tools/examples/xen-hotplug-common.sh
@@ -21,7 +21,7 @@ dir=$(dirname "$0")
 . "$dir/xen-script-common.sh"
 . "$dir/locking.sh"
 
-exec 2>>/var/log/xen-hotplug.log
+exec 2>>/var/log/xen/xen-hotplug.log
 
 export PATH="/sbin:/bin:/usr/bin:/usr/sbin:$PATH"
 export LANG="POSIX"
tools/examples/xend-config.sxp +1 -1
diff -r ec03b24a2d83 tools/examples/xend-config.sxp
@@ -11,7 +11,7 @@
 # Commented out entries show the default for that entry, unless otherwise
 # specified.
 
-#(logfile /var/log/xend.log)
+#(logfile /var/log/xen/xend.log)
 #(loglevel DEBUG)
 
 #(xend-http-server no)
tools/ioemu/patches/qemu-logging +1 -1
diff -r ec03b24a2d83 tools/ioemu/patches/qemu-logging
@@ -43,7 +43,7 @@ Index: ioemu/vl.c
      /* default mac address of the first network interface */
      
 +    /* init debug */
-+    sprintf(qemu_dm_logfilename, "/var/log/qemu-dm.%d.log", getpid());
++    sprintf(qemu_dm_logfilename, "/var/log/xen/qemu-dm.%d.log", getpid());
 +    cpu_set_log_filename(qemu_dm_logfilename);
 +    cpu_set_log(0);
 +    
tools/ioemu/vl.c +1 -1
diff -r ec03b24a2d83 tools/ioemu/vl.c
@@ -5924,7 +5924,7 @@ int main(int argc, char **argv)
     /* default mac address of the first network interface */
     
     /* init debug */
-    sprintf(qemu_dm_logfilename, "/var/log/qemu-dm.%d.log", getpid());
+    sprintf(qemu_dm_logfilename, "/var/log/xen/qemu-dm.%d.log", getpid());
     cpu_set_log_filename(qemu_dm_logfilename);
     cpu_set_log(0);
     
tools/misc/xend +1 -1
diff -r ec03b24a2d83 tools/misc/xend
@@ -86,7 +86,7 @@ def start_xenstored():
     XENSTORED_TRACE = os.getenv("XENSTORED_TRACE")
     cmd = "xenstored --pid-file /var/run/xenstore.pid"
     if XENSTORED_TRACE:
-        cmd += " -T /var/log/xenstored-trace.log"
+        cmd += " -T /var/log/xen/xenstored-trace.log"
     s,o = commands.getstatusoutput(cmd)
 
 def start_consoled():
tools/python/xen/util/bugtool.py +2 -2
diff -r ec03b24a2d83 tools/python/xen/util/bugtool.py
@@ -43,8 +43,8 @@ TITLE_RE = re.compile(r'<title>(.*)</tit
 
 FILES_TO_SEND = [ '/var/log/' + x for x in 
                   [ 'syslog', 'messages', 'debug',
-                    'xend.log', 'xend-debug.log', 'xenstored-trace.log',
-                    'xen-hotplug.log' ] ]
+                    'xen/xend.log', 'xen/xend-debug.log', 'xen/xenstored-trace.log',
+                    'xen/xen-hotplug.log' ] ]
 #FILES_TO_SEND = [  ]
 
 
tools/python/xen/xend/XendRoot.py +1 -1
diff -r ec03b24a2d83 tools/python/xen/xend/XendRoot.py
@@ -52,7 +52,7 @@ class XendRoot:
     block_script_dir = "/etc/xen/scripts"
 
     """Default path to the log file. """
-    logfile_default = "/var/log/xend.log"
+    logfile_default = "/var/log/xen/xend.log"
 
     """Default level of information to be logged."""
     loglevel_default = 'DEBUG'
tools/python/xen/xend/server/params.py +2 -2
diff -r ec03b24a2d83 tools/python/xen/xend/server/params.py
@@ -39,8 +39,8 @@ def getenv(var, val, conv=None):
 
 # The following parameters could be placed in a configuration file.
 XEND_PID_FILE      = '/var/run/xend.pid'
-XEND_TRACE_FILE    = '/var/log/xend.trace'
-XEND_DEBUG_LOG     = '/var/log/xend-debug.log'
+XEND_TRACE_FILE    = '/var/log/xen/xend.trace'
+XEND_DEBUG_LOG     = '/var/log/xen/xend-debug.log'
 XEND_USER          = 'root'
 XEND_DEBUG         = getenv("XEND_DEBUG",     0, conv=int)
 XEND_DAEMONIZE     = getenv("XEND_DAEMONIZE", not XEND_DEBUG, conv=int)
tools/security/python/xensec_gen/main.py +1 -1
diff -r ec03b24a2d83 tools/security/python/xensec_gen/main.py
@@ -34,7 +34,7 @@ import CGIHTTPServer
 
 gHttpPort = 7777
 gHttpDir  = '/var/lib/xensec_gen'
-gLogFile  = '/var/log/xensec_gen.log'
+gLogFile  = '/var/log/xen/xensec_gen.log'
 gUser     = 'nobody'
 gGroup    = 'nobody'
 

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 4 lines · Jeremy Katz

The attached patch moves all of the various log files created by xen to be under /var/log/xen instead of under /var/log directly. This has the advantage of cleaning things up a little[1] and also can make it easier to restrict the permissions needed by xend.

Any other thoughts on this?

Jeremy