Daily Xen Builds

PATCH In review David F Barrera 2 participants 5 messages Aug 30, 2006 – Sep 8, 2006

Share & tools

David F Barrera

author

2006-08-30 15:58 UTC #0 lore raw

August 30, 2006, using xen-unstable changeset:

changeset:   11288:a47951e59cbf
tag:         tip
user:        Ewan Mellor <[email protected]>
date:        Wed Aug 30 03:47:24 2006 +0100
summary:     Shadow memory should be in MiB, not KiB.  It also needs rounding up to be safe.

ISSUES:
* Bugzilla Bug 725 xm-test - FAIL: 11_create_concurrent_pos.test -- Console run-away (exceeded 131072 bytes)

x86_32 (no PAE support)

* SLES 9 SP2 on IBM xSeries 335, and 235
* Builds and boots without problems
* Able to create fully functional guest domains
* Ran xm-test on all boxes

x86_32 (PAE)

* FC4 on x335, RHEL 4 on IBM HS20 Blade
* Builds and boots without problems
* Able to create fully functional guest domains

ISSUES:

x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843)

Unable to start xen on this machine. Build log shows:

/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:1272: warning: missing sentinel in function call make[3]: *** [vnc.o] Error 1
make[2]: *** [subdir-i386-dm] Error 2
make[1]: *** [ioemu] Error 2
make: *** [all] Error 2
...
make[3]: *** [vnc.o] Error 1
make[2]: *** [subdir-i386-dm] Error 2
make[1]: *** [ioemuinstall] Error 2
make: *** [install] Error 2"

         x235-sles9 |  105 |    4 |     0 |     3 |
        x335fc4-PAE |  107 |    4 |     0 |     3 |
          x335sles9 |  107 |    4 |     0 |     3 |

Signature · 9 lines

Regards,

David F Barrera
Linux Technology Center
Systems and Technology Group, IBM

"The wisest men follow their own direction. "
	
                         Euripides

Xm-test execution summary:
PASS: 107
FAIL: 4
XPASS: 0
XFAIL: 3

Details:

FAIL: 11_create_concurrent_pos
Unknown reason

XFAIL: 02_network_local_ping_pos
ping loopback failed for size 65507. ping eth0 failed for size 65507.

XFAIL: 05_network_dom0_ping_pos
Ping to dom0 failed for size 65507.

XFAIL: 11_network_domU_ping_pos
Ping failed for size 65507.

Xm-test execution summary:
PASS: 107
FAIL: 4
XPASS: 0
XFAIL: 3

Details:

FAIL: 11_create_concurrent_pos
Unknown reason

XFAIL: 02_network_local_ping_pos
ping loopback failed for size 65507. ping eth0 failed for size 65507.

XFAIL: 05_network_dom0_ping_pos
Ping to dom0 failed for size 65507.

XFAIL: 11_network_domU_ping_pos
Ping failed for size 65507.

Xm-test execution summary:
PASS: 105
FAIL: 4
XPASS: 0
XFAIL: 3

Details:

FAIL: 11_create_concurrent_pos
Unknown reason

XFAIL: 02_network_local_ping_pos
ping loopback failed for size 65507. ping eth0 failed for size 65507.

XFAIL: 05_network_dom0_ping_pos
Ping to dom0 failed for size 65507.

XFAIL: 11_network_domU_ping_pos
Ping failed for size 65507.

_______________________________________________
Xen-devel mailing list [email protected]
http://lists.xensource.com/xen-devel

Harry Butterworth

2006-08-30 16:31 UTC #1 lore raw

PATCH 1/1 Fix sentinel in call to execlp in tools/iommu/vnc.c

Quoted 10 lines · David F Barrera

August 30, 2006, using xen-unstable changeset:
changeset: 11288:a47951e59cbf
ISSUES:
x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843)
Unable to start xen on this machine. Build log shows:

Quoted 10 lines

/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:1272: warning: missing sentinel in function call make[3]: *** [vnc.o] Error 1
make[2]: *** [subdir-i386-dm] Error 2
make[1]: *** [ioemu] Error 2
make: *** [all] Error 2
...
make[3]: *** [vnc.o] Error 1
make[2]: *** [subdir-i386-dm] Error 2
make[1]: *** [ioemuinstall] Error 2
make: *** [install] Error 2"

This patch should fix your problem here. I have not tested it. Please give it a go and report whether it is OK to be committed to the tree.

The issue is that 0 on a 64 bit machine is a 32 bit integer whereas the sentinel needs to be a 64 bit null pointer for the code to be correct.

Signed-off-by Harry Butterworth <[email protected]>

tools/ioemu/vnc.c +1 -1

diff -r dc773bf49664 -r 606ec67fb063 tools/ioemu/vnc.c
@@ -1269,7 +1269,7 @@
 	exit(1);
 
     case 0:	/* child */
-	execlp("vncviewer", "vncviewer", s, 0);
+	execlp("vncviewer", "vncviewer", s, (char *)NULL);
 	fprintf(stderr, "vncviewer execlp failed\n");
 	exit(1);

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

David F Barrera

author

2006-08-30 18:20 UTC #2 lore raw

Re: [PATCH] [UNTESTED] Fix sentinel in call to execlp in tools/iommu/vnc.c

Quoted 15 lines · Harry Butterworth

This patch should fix your problem here. I have not tested it. Please give it a go and report whether it is OK to be committed to the tree.
The issue is that 0 on a 64 bit machine is a 32 bit integer whereas the sentinel needs to be a 64 bit null pointer for the code to be correct.
Signed-off-by Harry Butterworth <[email protected]>
------------------------------------------------------------------------
diff -r dc773bf49664 -r 606ec67fb063 tools/ioemu/vnc.c

tools/ioemu/vnc.c line 1275

Quoted 8 lines

tools/ioemu/vnc.c +1 -1

@@ -1269,7 +1269,7 @@
 	exit(1);
 
     case 0:	/* child */
-	execlp("vncviewer", "vncviewer", s, 0);
+	execlp("vncviewer", "vncviewer", s, (char *)NULL);
 	fprintf(stderr, "vncviewer execlp failed\n");
 	exit(1);

Here's the tail end of what I get:

...
XK_Control_Lâ undeclared (first use in this function) /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:847: error: âXK_Alt_Lâ undeclared (first use in this function) /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:864: error: âXK_1â undeclared (first use in this function) /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:864: error: âXK_9â undeclared (first use in this function) make[4]: *** [vnc.o] Error 1
make[4]: Leaving directory `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/i386-dm'
make[3]: *** [subdir-i386-dm] Error 2
make[3]: Leaving directory `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu'
make[2]: *** [ioemuinstall] Error 2
make[2]: Leaving directory `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools'
make: *** [install-tools] Error 2

Signature · 9 lines

Regards,

David F Barrera
Linux Technology Center
Systems and Technology Group, IBM

"The wisest men follow their own direction. "
	
                         Euripides

Harry Butterworth

2006-08-31 13:14 UTC #3 lore raw

Re: Re: [PATCH] [UNTESTED] Fix sentinel in call to execlp in tools/iommu/vnc.c

Quoted 39 lines · David F Barrera

Quoted 15 lines · Harry Butterworth
This patch should fix your problem here. I have not tested it. Please give it a go and report whether it is OK to be committed to the tree.
The issue is that 0 on a 64 bit machine is a 32 bit integer whereas the sentinel needs to be a 64 bit null pointer for the code to be correct.
Signed-off-by Harry Butterworth <[email protected]>
------------------------------------------------------------------------
diff -r dc773bf49664 -r 606ec67fb063 tools/ioemu/vnc.c
tools/ioemu/vnc.c line 1275
Quoted 8 lines
tools/ioemu/vnc.c +1 -1
@@ -1269,7 +1269,7 @@
 	exit(1);
 
     case 0:	/* child */
-	execlp("vncviewer", "vncviewer", s, 0);
+	execlp("vncviewer", "vncviewer", s, (char *)NULL);
 	fprintf(stderr, "vncviewer execlp failed\n");
 	exit(1);
 
Here's the tail end of what I get:
...
XK_Control_Lâ undeclared (first use in this function) /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:847:
error: âXK_Alt_Lâ undeclared (first use in this function) /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:864:
error: âXK_1â undeclared (first use in this function) /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:864:
error: âXK_9â undeclared (first use in this function) make[4]: *** [vnc.o] Error 1
make[4]: Leaving directory `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/i386-dm' make[3]: *** [subdir-i386-dm] Error 2
make[3]: Leaving directory

Quoted 8 lines

`/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu' make[2]: *** [ioemuinstall] Error 2
make[2]: Leaving directory `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools' make[1]: *** [install] Error 2
make[1]: Leaving directory `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools'
make: *** [install-tools] Error 2

Well, my patch seems to have fixed your previous compile error so I think it is good. The errors above are unrelated to the patch.

The errors above indicate that the symbols XK_Alt_L XK_1 and XK_9 are undefined. (I don't understand where the weird 'â' characters are coming from in the error report above).

These symbols should be defined in /usr/include/X11/keysymdef.h which is included by vnc.c.

Please check that you have this header file installed on your build machine and that the symbols are defined in it.

Harry.

Harry Butterworth

2006-09-08 16:01 UTC #4 lore raw

Re: [PATCH] [UNTESTED] Fix sentinel in call to execlp in tools/iommu/vnc.c

In reply to Harry Butterworth

The following code in vnc.c needs to change. I'm not sure if the patch below is the way to change it or if it should be changed in tools/ioemu/patches/vnc-start-vncviewer or in both places.

Why is the code checked in in two places?

It's trivial, please commit a fix or explain exactly what is required and I'll re-spin the patch.

Harry.

Quoted 33 lines · Harry Butterworth

Quoted 10 lines · David F Barrera
August 30, 2006, using xen-unstable changeset:
changeset: 11288:a47951e59cbf
ISSUES:
x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843)
Unable to start xen on this machine. Build log shows:
Quoted 10 lines
/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:1272: warning: missing sentinel in function call make[3]: *** [vnc.o] Error 1
make[2]: *** [subdir-i386-dm] Error 2
make[1]: *** [ioemu] Error 2
make: *** [all] Error 2
...
make[3]: *** [vnc.o] Error 1
make[2]: *** [subdir-i386-dm] Error 2
make[1]: *** [ioemuinstall] Error 2
make: *** [install] Error 2"
This patch should fix your problem here. I have not tested it. Please give it a go and report whether it is OK to be committed to the tree.
The issue is that 0 on a 64 bit machine is a 32 bit integer whereas the sentinel needs to be a 64 bit null pointer for the code to be correct.
Signed-off-by Harry Butterworth <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel