Uninitialized variable in drivers/scsi/ncr53c8xx.c

hi,

this was spotted by coverity (id #880).
We use simple_strtoul() earlier to initialize pe, if the function fails, it also does not initialize it. Therefore we should initialize it ourselves, so the check in the OPT_TAGS case "if (pe && *pe == '/')" makes sense, and actually makes the command line parsing more robust.

Signed-off-by Eric Sesterhenn <[email protected]>

drivers/scsi/ncr53c8xx.c renamed from drivers/scsi/ncr53c8xx.c.orig +1 -1

@@ -692,7 +692,7 @@ static int __init sym53c8xx__setup(char 
 	int xi = 0;
 
 	while (cur != NULL && (pc = strchr(cur, ':')) != NULL) {
-		char *pe;
+		char *pe = NULL;
 
 		val = 0;
 		pv = pc;

Quoted 9 lines · On Fri, 01 Sep 2006 01:29:12 +0200 Eric Sesterhenn <[email protected]> wrote:

hi,

this was spotted by coverity (id #880).
We use simple_strtoul() earlier to initialize pe, if the function fails, it also does not initialize it. Therefore we should initialize it ourselves, so the check in the OPT_TAGS case "if (pe && *pe == '/')" makes sense, and actually makes the command line parsing more robust.

Quoted 1 line

Signed-off-by Eric Sesterhenn <[email protected]>

simple_strtoul() always initialises `pe'.