Skip to contentSkip to conversation

BUG_ON cleanup for drivers/md/

PATCH New Eric Sesterhenn 1 participant 1 message Sep 6, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 BUG_ON cleanup for drivers/md/

hi,

this changes two if() BUG(); usages to BUG_ON(); so people can disable it safely.

drivers/md/md.c renamed from drivers/md/md.c.orig +1 -2
@@ -4476,8 +4476,7 @@ static int md_release(struct inode *inod
 {
  	mddev_t *mddev = inode->i_bdev->bd_disk->private_data;
 
-	if (!mddev)
-		BUG();
+	BUG_ON(!mddev);
 	mddev_put(mddev);
 
 	return 0;
drivers/md/raid5.c renamed from drivers/md/raid5.c.orig +1 -1
@@ -1108,7 +1108,7 @@ static void compute_parity6(struct strip
 				if (test_and_clear_bit(R5_Overlap, &sh->dev[i].flags))
 					wake_up(&conf->wait_for_overlap);
 
-				if (sh->dev[i].written) BUG();
+				BUG_ON(sh->dev[i].written);
 				sh->dev[i].written = chosen;
 			}
 		break;

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors