Skip to contentSkip to conversation

alim15x3.c: M5229 (rev c8) support for DMA cd-writer

PATCH NAK Michael De Backer 2 participants 4 messages Sep 9, 2006 – Sep 10, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 alim15x3.c: M5229 (rev c8) support for DMA cd-writer

From: Michael De Backer <[email protected]>

Configuration bits are not set properly for DMA on some chipset revisions. It has already been corrected for M5229 (rev c7) but not for M5229 (rev c8). This leads to the bug described at
http://bugzilla.kernel.org/show_bug.cgi?id=5786 (lost interrupt + ide bus hangs).

---
This has been tested on ASUS A8R32-MVP motherboard (M5229 c8) with 2.6.18-rc6, 2.6.18-rc6-mm1, 2.6.18-rc5-mm1, 2.6.17.10 and two different cd-writers. It completely solves the problem.

The following patch is against the 2.6.18-rc6 or 2.6.18-rc6-mm1 kernel:

--- linux/drivers/ide/pci/alim15x3.c.orig 2006-09-09
16:07:07.000000000 +0200
+++ linux/drivers/ide/pci/alim15x3.c 2006-09-09 16:08:25.000000000
+0200
@@ -730,7 +730,7 @@ static unsigned int __devinit ata66_ali1

	if(m5229_revision <= 0x20)
		tmpbyte = (tmpbyte & (~0x02)) | 0x01;
-       else if (m5229_revision == 0xc7)
+       else if (m5229_revision == 0xc7 || 0xc8)
		tmpbyte |= 0x03;
	else
		tmpbyte |= 0x01;
#1 lore raw

Ar Sad, 2006-09-09 am 17:37 +0200, ysgrifennodd Michael De Backer:

Review

Quoted 2 lines
(quoted diff) +1 -1
-       else if (m5229_revision == 0xc7)
+       else if (m5229_revision == 0xc7 || 0xc8)

I don't think that is what you mean..

NAK

#2 lore raw
Quoted 7 lines · Alan Cox

Ar Sad, 2006-09-09 am 17:37 +0200, ysgrifennodd Michael De Backer:

Review

Quoted 2 lines
(quoted diff) +1 -1
-       else if (m5229_revision == 0xc7)
+       else if (m5229_revision == 0xc7 || 0xc8)

I don't think that is what you mean..

NAK

Indeed, let's try again (please forgive my dumbness).

Configuration bits are not set properly for DMA on some chipset revisions. It has already been corrected for M5229 (rev c7) but not for M5229 (rev c8). This leads to the bug described at
http://bugzilla.kernel.org/show_bug.cgi?id=5786 (lost interrupt + ide bus hangs).

---
The following patch is against the 2.6.18-rc6 or 2.6.18-rc6-mm1 kernel:

--- linux/drivers/ide/pci/alim15x3.c.orig 2006-09-09
16:07:07.000000000 +0200
+++ linux/drivers/ide/pci/alim15x3.c 2006-09-09 16:08:25.000000000
+0200
@@ -730,7 +730,7 @@ static unsigned int __devinit ata66_ali1

	if(m5229_revision <= 0x20)
		tmpbyte = (tmpbyte & (~0x02)) | 0x01;
-       else if (m5229_revision == 0xc7)
+       else if (m5229_revision == 0xc7 || m5229_revision == 0xc8)
		tmpbyte |= 0x03;
	else
		tmpbyte |= 0x01;
Acked-by
#3 lore raw

Ar Sad, 2006-09-09 am 21:12 +0200, ysgrifennodd Michael De Backer:

Quoted 4 lines
Quoted 3 lines

I don't think that is what you mean..

NAK

Indeed, let's try again (please forgive my dumbness).

I've just put at least a dumb a mistake in 2.6.18 final so I wouldnt worry - we all do it.

Quoted 7 lines

Configuration bits are not set properly for DMA on some chipset revisions. It has already been corrected for M5229 (rev c7) but not for M5229 (rev c8). This leads to the bug described at
http://bugzilla.kernel.org/show_bug.cgi?id=5786 (lost interrupt + ide bus hangs).