Skip to contentSkip to conversation

fix migrate_page_move_mapping for radix tree cleanup

PATCH In review Lee Schermerhorn 2 participants 2 messages Sep 13, 2006

Subsystems (2)
Memory management MM migration
lore
Share & tools
lore

Lee Schermerhorn

author
#0 lore raw

PATCH 1/1 fix migrate_page_move_mapping for radix tree cleanup

Alternative to my "revert migrate_move_mapping ..." patch:

Change to radix_tree_{deref|replace}_slot() API requires change to migrate_page_move_mapping() [only user of those APIs, so far] to eliminate compiler warnings.

Apply only after backing out the patch:

page-migration-replace-radix_tree_lookup_slot-with-radix_tree_lockup.patch

Signed-off-by Lee Schermerhorn <[email protected]>
 mm/migrate.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)
mm/migrate.c +5 -6
Index: linux-2.6.18-rc6-mm2/mm/migrate.c
===================================================================
@@ -294,7 +294,7 @@ out:
 static int migrate_page_move_mapping(struct address_space *mapping,
 		struct page *newpage, struct page *page)
 {
-	struct page **radix_pointer;
+	void **pslot;
 
 	if (!mapping) {
 		/* Anonymous page */

@@ -305,12 +305,11 @@ static int migrate_page_move_mapping(str
 
 	write_lock_irq(&mapping->tree_lock);
 
-	radix_pointer = (struct page **)radix_tree_lookup_slot(
-						&mapping->page_tree,
-						page_index(page));
+	pslot = radix_tree_lookup_slot(&mapping->page_tree,
+					page_index(page));
 
 	if (page_count(page) != 2 + !!PagePrivate(page) ||
-			radix_tree_deref_slot(radix_pointer) != page) {
+			(struct page *)radix_tree_deref_slot(pslot) != page) {
 		write_unlock_irq(&mapping->tree_lock);
 		return -EAGAIN;
 	}

@@ -326,7 +325,7 @@ static int migrate_page_move_mapping(str
 	}
 #endif
 
-	radix_tree_replace_slot(radix_pointer, newpage);
+	radix_tree_replace_slot(pslot, newpage);
 	__put_page(page);
 	write_unlock_irq(&mapping->tree_lock);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>