Skip to contentSkip to conversation

Fix xen-unstable build

PATCH In review Bryan O'Sullivan 4 participants 6 messages Sep 22, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix xen-unstable build

This patch is needed for a current xen-unstable build to complete. This file appears to have been broken for almost two months.

	<b
tools/ioemu/usb-linux.c +0 -1
diff -r 8c29bf7ede67 tools/ioemu/usb-linux.c
@@ -26,7 +26,6 @@
 #if defined(__linux__)
 #include <dirent.h>
 #include <sys/ioctl.h>
-#include <linux/compiler.h>
 #include <linux/usbdevice_fs.h>
 #include <linux/version.h>
#1 lore raw
Quoted 3 lines

This patch is needed for a current xen-unstable build to complete. This file appears to have been broken for almost two months.

Obviously not been broken for us - what compiler / distro are you using? What arch?

cheers,

S.

#2 lore raw
Quoted 5 lines · Steven Hand
Quoted 2 lines

This patch is needed for a current xen-unstable build to complete. This file appears to have been broken for almost two months.

Obviously not been broken for us - what compiler / distro are you using? What arch?

FC6t3, i386. I literally just ran "make" in a clean repo, didn't diddle anything.

	<b
#3 lore raw
Quoted 6 lines · Steven Hand
Quoted 1 line
Quoted 1 line

This patch is needed for a current xen-unstable build to complete.

This

Quoted 3 lines
Quoted 1 line

file appears to have been broken for almost two months.

Obviously not been broken for us - what compiler / distro are you

using?

Quoted 3 lines
Quoted 1 line

What arch?

FC6t3, i386. I literally just ran "make" in a clean repo, didn't

diddle

Quoted 1 line

anything.

I expect RH have an outstanding patch that fixes the compile error for their packaging of xen in FC6, but it's worth mentioning that you're using a pre-release distro with a bleeding edge compiler if you're going to complain about a build error! (or any other bug for that matter)

Thanks,
Ian

#4 lore raw
Quoted 4 lines · Ian Pratt

I expect RH have an outstanding patch that fixes the compile error for their packaging of xen in FC6, but it's worth mentioning that you're using a pre-release distro with a bleeding edge compiler if you're going to complain about a build error! (or any other bug for that matter)

The build breakage didn't appear to be compiler- or distro-related. I guess I was distracted by the thicket of kernel trees, and assumed that something was trying to include a file from one of those...

	<b
#5 lore raw
In reply to Steven Hand
Quoted 4 lines · Steven Hand
Quoted 2 lines

This patch is needed for a current xen-unstable build to complete. This file appears to have been broken for almost two months.

Obviously not been broken for us - what compiler / distro are you using? What arch?

Yeah, it has been broken for me; I just keep removing it without getting around to making a patch. The include is completely bogus anyway. I think it's in upstream qemu, and it's bogus there too.

J