Skip to contentSkip to conversation

remove old z90crypt driver.

S390 David Woodhouse 2 participants 3 messages Sep 24, 2006 – Sep 25, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 6 lines · Linux Kernel Mailing List

[S390] remove old z90crypt driver.

The z90crypt driver has served its term. It is replaced by the shiny new zcrypt device driver.

You neglected to remove the defunct z90crypt.h from include/asm-s390/Kbuild, breaking 'make headers_install' on s390.

You also neglected to export the new asm/zcrypt.h too. This should fix both:

include/asm-s390/Kbuild +1 -1
@@ -6,7 +6,7 @@ header-y += qeth.h
 header-y += tape390.h
 header-y += ucontext.h
 header-y += vtoc.h
-header-y += z90crypt.h
+header-y += zcrypt.h
 
 unifdef-y += cmb.h
 unifdef-y += debug.h
Signature · 1 line
dwmw2
#2 lore raw
Quoted 12 lines · David Woodhouse

You neglected to remove the defunct z90crypt.h from include/asm-s390/Kbuild, breaking 'make headers_install' on s390.

You also neglected to export the new asm/zcrypt.h too. This should fix both:

include/asm-s390/Kbuild header-y += qeth.h · line 12

Quoted 8 lines
include/asm-s390/Kbuild +1 -1
@@ -6,7 +6,7 @@ header-y += qeth.h
 header-y += tape390.h
 header-y += ucontext.h
 header-y += vtoc.h
-header-y += z90crypt.h
+header-y += zcrypt.h
 
 unifdef-y += cmb.h
 unifdef-y += debug.h

Unfortunately true. The patches for the new crypto driver originate from before headers_install. I forgot to update them accordingly .. Anyway, thanks for the heads up. I'll add the patch to git390.

Signature · 8 lines
blue skies,
  Martin.

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH

"Reality continues to ruin my life." - Calvin.
#3 lore raw
Quoted 3 lines · Martin Schwidefsky

Unfortunately true. The patches for the new crypto driver originate from before headers_install. I forgot to update them accordingly .. Anyway, thanks for the heads up. I'll add the patch to git390.

It's in Linus' tree already.

Signature · 1 line
dwmw2