avoid NULL pointer in gpio1_interrupt
PATCH 1/1 avoid NULL pointer in gpio1_interrupt
gpio1_interrupt() may dereference a NULL pointer if ioremap() fails. But, maybe no gpio interrupt happens in the first place?
Signed-off-by Olaf Hering <[email protected]>
--- drivers/macintosh/via-pmu.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/macintosh/via-pmu.c +6 -1
@@ -336,8 +336,10 @@ int __init find_via_pmu(void)if (gaddr !=OF_BAD_ADDR ) gpio_reg =ioremap (gaddr,0x10 ); } -if (gpio_reg ==NULL ) +if (gpio_reg ==NULL ) {printk (KERN_ERR "via-pmu: Can't find GPIO reg !\n" ); + goto fail_gpio; + } }else pmu_kind =PMU_UNKNOWN ;
@@ -366,6 +368,9 @@ int __init find_via_pmu(void)return 1 ; fail:of_node_put (vias); +iounmap (gpio_reg); + gpio_reg =NULL ; + fail_gpio: vias =NULL ;return 0 ; }
Quoted 2 lines · Olaf Hering
gpio1_interrupt()may dereference a NULL pointer ifioremap()fails. But, maybe no gpio interrupt happens in the first place?
Nah, they would happen. Good catch tho I fail to see how ioremap would fail that early during boot :)
Ben.