Skip to contentSkip to conversation

i2c-isa: Fail adding driver on

PATCH New Greg KH 1 participant 1 message Sep 27, 2006 I2C subsystem host drivers

lore
Share & tools
lore

Greg KH

author
#0 lore raw

PATCH 20/30 i2c-isa: Fail adding driver on

From: David Hubbard <david.c.hubbard at gmail.com>

i2c-isa: Fail adding driver on attach_adapter error

Signed-off-by David Hubbard <david.c.hubbard at gmail.com>
Signed-off-by Jean Delvare <khali at linux-fr.org>
Signed-off-by Greg Kroah-Hartman <gregkh at suse.de>
---
 drivers/i2c/busses/i2c-isa.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)
drivers/i2c/busses/i2c-isa.c +8 -3
index d7486e5..7a8d2c1 100644
@@ -89,9 +89,14 @@ int i2c_isa_add_driver(struct i2c_driver
 	dev_dbg(&isa_adapter.dev, "Driver %s registered\n", driver->driver.name);
 
 	/* Now look for clients */
-	driver->attach_adapter(&isa_adapter);
-
-	return 0;
+	res = driver->attach_adapter(&isa_adapter);
+	if (res) {
+		dev_err(&isa_adapter.dev,
+			"Driver %s failed to attach adapter, unregistering\n",
+			driver->driver.name);
+		driver_unregister(&driver->driver);
+	}
+	return res;
 }
 
 int i2c_isa_del_driver(struct i2c_driver *driver)
Signature · 1 line
1.4.2.1