Skip to contentSkip to conversation

debugfs oddity

DISCUSSION Johannes Berg 2 participants 5 messages Oct 2, 2006 – Oct 4, 2006

lore
Share & tools
lore
#0 lore raw

Recently, I observed (in bcm43xx) that debugfs seems to keep things alive when userspace still has a directory open. Consider the following sequence of events:
(a) kernel code creates a directory in debugfs
(b) user changes current directory to that
(c) kernel code removes that directory in debugfs

Now, consider the equivalent sequence in a regular filesystem (or tmpfs):
(a') user creates directory
(b') user cd's into it
(c') user deletes directory from a different shell

The same thing should happen, in both cases the directory is kept around in a way until the process that has the current dir in the dead directory gives it up.

Now, however, consider
(d') user creates directory with the same name

This works fine, and the old process sees nothing that happens in the new directory, as expected. However,
(d) kernel code tries to create a debugfs directory with the same name

does not work at all.

Is this expected behaviour? It seems that once a driver requested that a directory is removed it can rightfully expect to be able to recreate it afterwards even if there's still the need to keep it lingering around for a bit.

Similar things can probably happen when attributes are kept open, but I haven't tested this. I have also not tested sysfs or configfs.

johannes

#1 lore raw
Quoted 17 lines · Johannes Berg

Recently, I observed (in bcm43xx) that debugfs seems to keep things alive when userspace still has a directory open. Consider the following sequence of events:
(a) kernel code creates a directory in debugfs
(b) user changes current directory to that
(c) kernel code removes that directory in debugfs

Now, consider the equivalent sequence in a regular filesystem (or tmpfs):
(a') user creates directory
(b') user cd's into it
(c') user deletes directory from a different shell

The same thing should happen, in both cases the directory is kept around in a way until the process that has the current dir in the dead directory gives it up.

Quoted 8 lines

Now, however, consider
(d') user creates directory with the same name

This works fine, and the old process sees nothing that happens in the new directory, as expected. However,
(d) kernel code tries to create a debugfs directory with the same name

does not work at all.

True, that is because the kernel thinks there is still an active dentry with that name present in the system.

Quoted 7 lines

Is this expected behaviour? It seems that once a driver requested that a directory is removed it can rightfully expect to be able to recreate it afterwards even if there's still the need to keep it lingering around for a bit.

Similar things can probably happen when attributes are kept open, but I haven't tested this. I have also not tested sysfs or configfs.

sysfs works much differently here, as does configfs. debugfs just uses the vfs layer's ramfs stack, so any potential problem here is probably also present in ramfs. Have you tried that out?

thanks,

greg k-h

#2 lore raw
Quoted 3 lines · Greg KH

sysfs works much differently here, as does configfs. debugfs just uses the vfs layer's ramfs stack, so any potential problem here is probably also present in ramfs. Have you tried that out?

Just had a go -- ramfs works as expected, at least when I do the dance from userspace as I had in (a')-(d').

johannes

#3 lore raw
Quoted 8 lines · Johannes Berg
Quoted 3 lines · Greg KH

sysfs works much differently here, as does configfs. debugfs just uses the vfs layer's ramfs stack, so any potential problem here is probably also present in ramfs. Have you tried that out?

Just had a go -- ramfs works as expected, at least when I do the dance from userspace as I had in (a')-(d').

I don't understand. Does ramfs have the same issues you feel debugfs has? Or does it work like a disk based file system?

thanks,

greg k-h

#4 lore raw
Quoted 2 lines · Greg KH

I don't understand. Does ramfs have the same issues you feel debugfs has? Or does it work like a disk based file system?

It works like tmpfs and disk based filesystems and allows re-creating a removed directory.

johannes