Skip to contentSkip to conversation

Remove unnecessary check in fs/fat/inode.c

PATCH In review Eric Sesterhenn 2 participants 2 messages Oct 4, 2006 VFAT/FAT/msdos filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove unnecessary check in fs/fat/inode.c

hi,

since all callers dereference sb, and this function does so earlier too, we dont need the check.

fs/fat/inode.c renamed from fs/fat/inode.c.orig +1 -1
@@ -1472,7 +1472,7 @@ int fat_flush_inodes(struct super_block 
 		ret = writeback_inode(i1);
 	if (!ret && i2)
 		ret = writeback_inode(i2);
-	if (!ret && sb) {
+	if (!ret) {
 		struct address_space *mapping = sb->s_bdev->bd_inode->i_mapping;
 		ret = filemap_flush(mapping);
 	}
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Eric Sesterhenn

since all callers dereference sb, and this function does so earlier too, we dont need the check.

fs/fat/inode.c int fat_flush_inodes(struct super_block · line 1478

Quoted 8 lines
fs/fat/inode.c renamed from fs/fat/inode.c.orig +1 -1
@@ -1472,7 +1472,7 @@ int fat_flush_inodes(struct super_block 
 		ret = writeback_inode(i1);
 	if (!ret && i2)
 		ret = writeback_inode(i2);
-	if (!ret && sb) {
+	if (!ret) {
 		struct address_space *mapping = sb->s_bdev->bd_inode->i_mapping;
 		ret = filemap_flush(mapping);
 	}

Thanks.

Signature · 1 line
OGAWA Hirofumi <[email protected]>