Skip to contentSkip to conversation

Rename pdc_init

PATCH In review Matthew Wilcox 3 participants 6 messages Oct 6, 2006 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Rename pdc_init

parisc uses pdc_init() for different purposes, so call it pdc202xx_init instead.

---
 drivers/ata/pata_pdc202xx_old.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/ata/pata_pdc202xx_old.c +4 -4
index 5ba9eb2..8850ed5 100644
@@ -402,12 +402,12 @@ static struct pci_driver pdc_pci_driver 
 	.remove		= ata_pci_remove_one
 };
 
-static int __init pdc_init(void)
+static int __init pdc202xx_init(void)
 {
 	return pci_register_driver(&pdc_pci_driver);
 }
 
-static void __exit pdc_exit(void)
+static void __exit pdc202xx_exit(void)
 {
 	pci_unregister_driver(&pdc_pci_driver);
 }
@@ -418,5 +418,5 @@ MODULE_LICENSE("GPL");
 MODULE_DEVICE_TABLE(pci, pdc);
 MODULE_VERSION(DRV_VERSION);
 
-module_init(pdc_init);
-module_exit(pdc_exit);
+module_init(pdc202xx_init);
+module_exit(pdc202xx_exit);
Signature · 1 line
1.4.1.1
#1 lore raw
Quoted 4 lines · Matthew Wilcox

parisc uses pdc_init() for different purposes, so call it pdc202xx_init instead.

I don't mind the patch (you should have CC'd me and linux-ide though), but where is parisc's pdc_init actually used, and why is it global?

Jeff

#2 lore raw
Quoted 1 line · Jeff Garzik

I don't mind the patch (you should have CC'd me and linux-ide though),

We really need to figure out how to communicate that better. I just sent it to the maintainer (as listed in MODULE_AUTHOR). Do we need a MODULE_CHANGES_CC macro too?

Quoted 1 line

but where is parisc's pdc_init actually used, and why is it global?

Hmm. Embarrassing. Seems it's a stale prototype; I'll delete it.

OTOH, there is a pdc_init in avr32, and it's prudent to not have two functions of the same name, so that you know which one is appearing in a backtrace. So it might be a good idea to apply this patch anyway.

#3 lore raw
In reply to Jeff Garzik

Ar Gwe, 2006-10-06 am 12:42 -0400, ysgrifennodd Jeff Garzik:

Quoted 8 lines
Quoted 4 lines · Matthew Wilcox

parisc uses pdc_init() for different purposes, so call it pdc202xx_init instead.

I don't mind the patch (you should have CC'd me and linux-ide though), but where is parisc's pdc_init actually used, and why is it global?

Can you cc me the patch as well ?

#4 lore raw
Quoted 11 lines · Alan Cox

Ar Gwe, 2006-10-06 am 12:42 -0400, ysgrifennodd Jeff Garzik:

Quoted 8 lines
Quoted 4 lines · Matthew Wilcox

parisc uses pdc_init() for different purposes, so call it pdc202xx_init instead.

I don't mind the patch (you should have CC'd me and linux-ide though), but where is parisc's pdc_init actually used, and why is it global?

Can you cc me the patch as well ?

Um, I did. Did your spamfilter eat it?

From: Matthew Wilcox <[email protected]>
To: Alan Cox <[email protected]>
Cc: [email protected], Matthew Wilcox <[email protected]>

#5 lore raw

Ar Gwe, 2006-10-06 am 11:07 -0600, ysgrifennodd Matthew Wilcox:

Quoted 3 lines
Quoted 1 line

Can you cc me the patch as well ?

Um, I did. Did your spamfilter eat it?

Ah found it, no my filters filed it under parisc 8)

"NAK" to the patch as is because the other drivers for consistency use the same prefix for all functions for the same chip. I will however add a TODO note to myself to rename them all properly next time I work on that driver.

Alan