Skip to contentSkip to conversation

pata_marvell: Marvell 6101/6145 PATA driver

PATCH In review Alan Cox 3 participants 4 messages Oct 16, 2006 – Oct 17, 2006 libata

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

PATCH 1/1 pata_marvell: Marvell 6101/6145 PATA driver

This is a legacy mode PATA driver for the 6101/45 and will also drive the SATA ports 1 & 2 in legacy mode as well if desired. Tested and confirmed working by users. The chip supports AHCI type behaviour for SATA and has a more advanced PATA interface as well so this driver will get it working but not get best performance for now.

drivers/ata/Kconfig +9 -0
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.19-rc1-mm1/drivers/ata/Kconfig linux-2.6.19-rc1-mm1/drivers/ata/Kconfig
@@ -341,6 +341,15 @@
 
 	  If unsure, say N.
 
+config PATA_MARVELL
+	tristate "Marvell PATA support via legacy mode"
+	depends on PCI
+	help
+	  This option enables limited support for the Marvell 88SE6145 ATA
+	  controller.
+
+	  If unsure, say N.
+
 config PATA_MPIIX
 	tristate "Intel PATA MPIIX support"
 	depends on PCI
drivers/ata/Makefile +1 -0
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.19-rc1-mm1/drivers/ata/Makefile linux-2.6.19-rc1-mm1/drivers/ata/Makefile
@@ -38,6 +38,7 @@
 obj-$(CONFIG_PATA_NS87410)	+= pata_ns87410.o
 obj-$(CONFIG_PATA_OPTI)		+= pata_opti.o
 obj-$(CONFIG_PATA_OPTIDMA)	+= pata_optidma.o
+obj-$(CONFIG_PATA_MARVELL)	+= pata_marvell.o
 obj-$(CONFIG_PATA_MPIIX)	+= pata_mpiix.o
 obj-$(CONFIG_PATA_OLDPIIX)	+= pata_oldpiix.o
 obj-$(CONFIG_PATA_PCMCIA)	+= pata_pcmcia.o
drivers/ata/pata_marvell.c +221 -0

221 lines not on this page · raw message

#1 lore raw

drivers/ata/pata_marvell.c line 43

Quoted 12 lines · On Mon, 16 Oct 2006 16:40:06 +0100 Alan Cox <[email protected]> wrote:
drivers/ata/pata_marvell.c +12 -0
+static int marvell_pre_reset(struct ata_port *ap)
+{
+	struct pci_dev *pdev = to_pci_dev(ap->host->dev);
+	u32 devices;
+	unsigned long bar5;
+	void __iomem *barp;
+	int i;
+
+	/* Check if our port is enabled */
+
+	bar5 = pci_resource_start(pdev, 5);
+	barp = ioremap(bar5, 0x10);

hm. pci_resource_start() returns a possibly-64-bit resource_size_t nowadays. But ioremap() doesn't know how to remap such a thing.

#2 lore raw
Quoted 18 lines · Andrew Morton

drivers/ata/pata_marvell.c line 43

Quoted 12 lines · On Mon, 16 Oct 2006 16:40:06 +0100 Alan Cox <[email protected]> wrote:
drivers/ata/pata_marvell.c +12 -0
+static int marvell_pre_reset(struct ata_port *ap)
+{
+	struct pci_dev *pdev = to_pci_dev(ap->host->dev);
+	u32 devices;
+	unsigned long bar5;
+	void __iomem *barp;
+	int i;
+
+	/* Check if our port is enabled */
+
+	bar5 = pci_resource_start(pdev, 5);
+	barp = ioremap(bar5, 0x10);

hm. pci_resource_start() returns a possibly-64-bit resource_size_t nowadays. But ioremap() doesn't know how to remap such a thing.

These days, pci_iomap() should be used anyway.

Jeff

author
#3 lore raw

Ar Llu, 2006-10-16 am 19:48 -0400, ysgrifennodd Jeff Garzik:

Quoted 4 lines
Quoted 2 lines

hm. pci_resource_start() returns a possibly-64-bit resource_size_t nowadays. But ioremap() doesn't know how to remap such a thing.

These days, pci_iomap() should be used anyway.

Updated to pci_iomap and will push that next time around