powerpc: Support for MPIC on native cell
Subsystems (2)
PATCH 1/1 powerpc: Support for MPIC on native cell
Add support for southbridges using the MPIC interrupt controller to the native cell platforms.
arch/powerpc/Kconfig +1 -0
@@ -461,6 +461,7 @@ config PPC_CELL_NATIVE bool select PPC_CELL select PPC_DCR_MMIO + select MPIC default n config PPC_IBM_CELL_BLADE
arch/powerpc/platforms/cell/setup.c +44 -0
60 lines not on this page · raw message
Quoted 1 line · Benjamin Herrenschmidt
+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0/* The MPIC driver will get=
everything it needs from the
Quoted 1 line
+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 * device-tree, just pass 0=
to all arguments
Quoted 2 lines
+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 */ +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0mpic =3D mpic_alloc(dn, 0, =
0, 0, 0, " MPIC =A0 =A0 ");
Do you expect future users to do the same and just pass zeroes? If so, maybe we should add a small wrapper like
static inline struct mpic *mpic_probe(struct device_node *dn)
{
return mpic_alloc(dn, 0, 0, 0, 0, " MPIC ");
}in <asm/mpic.h>
Arnd <><
Quoted 6 lines · Arnd Bergmann
arch/powerpc/platforms/cell/setup.c static void __init cell_pcibios_fixup(vo · line 117
Quoted 4 lines · Benjamin Herrenschmidt
arch/powerpc/platforms/cell/setup.c +4
-0+/* The MPIC driver will get everything it needs from the +* device-tree, just pass 0 to all arguments +*/ + mpic =mpic_alloc (dn,0 ,0 ,0 ,0 ," MPIC " );
Quoted 7 lines
Do you expect future users to do the same and just pass zeroes? If so, maybe we should add a small wrapper like
static inline struct mpic *mpic_probe(struct
device_node*dn){ return mpic_alloc(dn, 0, 0, 0, 0, " MPIC "); }
Possibly... there are still flags that it can't figure out by itself, like segher never put "big-endian" in the SLOF DT of the blades etc...
But yes, I might move in that direction.
Ben.