gfs2_dir_read_data(): fix uninitialized variable usage
PATCH 8/8 gfs2_dir_read_data(): fix uninitialized variable usage
Quoted 1 line
From
b7d8ac3e1779c30ddef0a8f38042076c5007a23dMon Sep 17 00:00:00 2001
From: Adrian Bunk <[email protected]>
Date: Thu, 19 Oct 2006 16:02:07 +0200
Subject: [GFS2] gfs2_dir_read_data(): fix uninitialized variable usage
In the "if (extlen)" case, "bh" was used uninitialized.
This patch changes the code to what seems to have been intended.
Spotted by the Coverity checker.
This patch also removes a pointless "bh = NULL" asignment (the variable is never accessed again after this point).
Signed-off-by Adrian Bunk <[email protected]>
Signed-off-by Steven Whitehouse <[email protected]>
--- fs/gfs2/dir.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
fs/gfs2/dir.c +1 -3
@@ -315,8 +315,7 @@ static int gfs2_dir_read_data(struct gfsif (!ra) extlen =1 ; bh =gfs2_meta_ra (ip->i_gl, dblock, extlen); - } -if (!bh) { + }else { error =gfs2_meta_read (ip->i_gl, dblock,DIO_WAIT , &bh);if (error) goto fail;
@@ -330,7 +329,6 @@ static int gfs2_dir_read_data(struct gfs extlen--;memcpy (buf, bh->b_data + o, amount);brelse (bh); - bh =NULL ; buf += amount; copied += amount; lblock++;
Signature · 1 line
1.4.1