Skip to contentSkip to conversation

Remove logic error in /Documentation/devices.txt

PATCH RESEND In review Marcus Fischer 2 participants 2 messages Oct 22, 2006 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 Remove logic error in /Documentation/devices.txt

Hello all,

can someone please tell me what I'm doing wrong with this commit? I'm lacking experience, but I thought I understood the process correct.

Please send me some feedback that I can rework/modify the patch if required.

Thanks,
Marcus

PS: Please CC me, I'm not on this list.

commit 51f3fe947923f6e775031cc1d538de6cf06ec77d

Author: Marcus Fischer <[email protected]>
Date:   Fri Sep 29 23:50:01 2006 +0200
    I found an logic error in the following commit:
    
        author    Steven Haigh <[email protected]>
                  Tue, 8 Aug 2006 21:42:06 +0000 (07:42 +1000)
        committer Greg Kroah-Hartman <[email protected]>
                  Wed, 27 Sep 2006 18:58:59 +0000 (11:58 -0700)
        commit    03270634e242dd10cc8569d31a00659d25b2b8e7
        tree      8f4665eb7b17386e733fcdc7d02e87c4a1592550
        parent    8ac283ad415358f022498887811c35ac656b5222

Documentation/devices.txt may either say
../adutux10 11th OntrackADU device or
../adutux9 10th Ontrack ADU device.

Anyway, the original one makes no sense:

+ 67 = /dev/usb/adutux0 1st Ontrak ADU device
+ ...
+ 76 = /dev/usb/adutux10 10th Ontrak ADU device

This patch removes the logic error.

However, I saw that MAX_DEVICES is 16. Thus, shouldn't this docu then say:
"81 = /dev/usb/adutux15 16th Ontrack ADU device" ?

Best,
Marcus

---

Documentation/devices.txt +0 -0
index addc67b..37efae8 100644
@@ -2545,7 +2545,7 @@ Your cooperation is appreciated.

66 = /dev/usb/cpad0 Synaptics cPad (mouse/LCD)
67 = /dev/usb/adutux0 1st Ontrak ADU device

    ...
- 76 = /dev/usb/adutux10 10th Ontrak ADU device
+ 76 = /dev/usb/adutux9 10th Ontrak ADU device
96 = /dev/usb/hiddev0 1st USB HID device
    ...

111 = /dev/usb/hiddev15 16th USB HID device

#1 lore raw
Quoted 1 line · Marcus Fischer

Hello all,

Hallo, Marcus.

Quoted 2 lines

can someone please tell me what I'm doing wrong with this commit? I'm lacking experience, but I thought I understood the process correct.

Yes. I think there is an error with numbering of devices set. And your effort to fix it appreciated.

Quoted 1 line

Please send me some feedback that I can rework/modify the patch if required.

[]

Quoted 1 line

PS: Please CC me, I'm not on this list.

Add yourself there, you'll have a copy to check your patch again, or carefully construct "Mail-Followup-To" header.

Also. If you've read top of devices.txt, you must have read about name and e-mail of the current maintainer of that file (i've added him). Finally one may think, this is a trivial fix, so <[email protected]> can be e-mailed also.

Quoted 30 lines

commit 51f3fe947923f6e775031cc1d538de6cf06ec77d

Author: Marcus Fischer <[email protected]>
Date:   Fri Sep 29 23:50:01 2006 +0200
    I found an logic error in the following commit:
    
        author    Steven Haigh <[email protected]>
                  Tue, 8 Aug 2006 21:42:06 +0000 (07:42 +1000)
        committer Greg Kroah-Hartman <[email protected]>
                  Wed, 27 Sep 2006 18:58:59 +0000 (11:58 -0700)
        commit    03270634e242dd10cc8569d31a00659d25b2b8e7
        tree      8f4665eb7b17386e733fcdc7d02e87c4a1592550
        parent    8ac283ad415358f022498887811c35ac656b5222

Documentation/devices.txt may either say
../adutux10 11th OntrackADU device or
../adutux9 10th Ontrack ADU device.

Anyway, the original one makes no sense:

+ 67 = /dev/usb/adutux0 1st Ontrak ADU device
+ ...
+ 76 = /dev/usb/adutux10 10th Ontrak ADU device

This patch removes the logic error.

However, I saw that MAX_DEVICES is 16. Thus, shouldn't this docu then say:
"81 = /dev/usb/adutux15 16th Ontrack ADU device" ?

Quoted 7 lines

Best,
Marcus

---

I think format of the patch isn't like suggested in "tpp", please care to give a short view to it:
<http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt>

and if you're using git, adjust git's tools to generate needed form of a patch.

Quoted 7 lines
Documentation/devices.txt +0 -0
index addc67b..37efae8 100644
@@ -2545,7 +2545,7 @@ Your cooperation is appreciated.
 66 = /dev/usb/cpad0 Synaptics cPad (mouse/LCD)

67 = /dev/usb/adutux0 1st Ontrak ADU device

Quoted 6 lines
    ...
- 76 = /dev/usb/adutux10 10th Ontrak ADU device
+ 76 = /dev/usb/adutux9 10th Ontrak ADU device
96 = /dev/usb/hiddev0 1st USB HID device
    ...

111 = /dev/usb/hiddev15 16th USB HID device

Good luck.
____