Skip to contentSkip to conversation

IA64 Kdump don't clear vector in kexec_disable_iosapic

PATCH New Zou Nan hai 1 participant 1 message Oct 25, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IA64 Kdump don't clear vector in kexec_disable_iosapic

Hi Tony,
This patch is from Naoaki-san.
Mask IOSAPIC will make the following EOI write to IOSAPIC fail because
IOSAPIC will not be able to find RTE entry.
However move EOI write before IOSAPIC mask will leave a small
racy windows between them for interrupts. So mask IOSAPIC but leave the vector field.

The patch is against your test tree.

arch/ia64/kernel/iosapic.c +1 -1
@@ -303,7 +303,7 @@ kexec_disable_iosapic(void)
 				rte_list) {
 			iosapic_write(rte->addr,
 					IOSAPIC_RTE_LOW(rte->rte_index),
-					IOSAPIC_MASK);
+					IOSAPIC_MASK|vec);
 			iosapic_eoi(rte->addr, vec);
 		}
 	}