Skip to contentSkip to conversation

powerpc: windfarm requests missing modules

PATCH New Benjamin Herrenschmidt 1 participant 1 message Nov 1, 2006 Linux for power macintosh

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: windfarm requests missing modules

The windfarm code, in it's current incarnation, uses request_module() to load the various submodules it needs for a given platform so that only the main platform control module needs to be modprobed. However, it was missing various bits. This fixes it. In the future, we'll use some hotplug mecanisms to try to get all of this auto-loaded on the platforms where it matters but that isn't ready yet.

---

I consider this a bug fix, could go in 2.6.19

drivers/macintosh/windfarm_pm112.c +11 -0
Index: linux-work/drivers/macintosh/windfarm_pm112.c
===================================================================
@@ -685,6 +685,17 @@ static int __init wf_pm112_init(void)
 		++nr_cores;
 
 	printk(KERN_INFO "windfarm: initializing for dual-core desktop G5\n");
+
+#ifdef MODULE
+	request_module("windfarm_smu_controls");
+	request_module("windfarm_smu_sensors");
+	request_module("windfarm_smu_sat");
+	request_module("windfarm_lm75_sensor");
+	request_module("windfarm_max6690_sensor");
+	request_module("windfarm_cpufreq_clamp");
+
+#endif /* MODULE */
+
 	platform_driver_register(&wf_pm112_driver);
 	return 0;
 }
drivers/macintosh/windfarm_pm81.c +1 -0
Index: linux-work/drivers/macintosh/windfarm_pm81.c
===================================================================
@@ -788,6 +788,7 @@ static int __init wf_smu_init(void)
 		request_module("windfarm_smu_controls");
 		request_module("windfarm_smu_sensors");
 		request_module("windfarm_lm75_sensor");
+		request_module("windfarm_cpufreq_clamp");
 
 #endif /* MODULE */
 		platform_driver_register(&wf_smu_driver);
drivers/macintosh/windfarm_pm91.c +1 -0
Index: linux-work/drivers/macintosh/windfarm_pm91.c
===================================================================
@@ -719,6 +719,7 @@ static int __init wf_smu_init(void)
 		request_module("windfarm_smu_controls");
 		request_module("windfarm_smu_sensors");
 		request_module("windfarm_lm75_sensor");
+		request_module("windfarm_cpufreq_clamp");
 
 #endif /* MODULE */
 		platform_driver_register(&wf_smu_driver);