Fix kref_put oops [4/5]
Quoted 1 line
From
ba542e3b92f9ea7c482ae56b68b9122eebc53a39Mon Sep 17 00:00:00 2001
From: Patrick Caulfield <[email protected]>
Date: Thu, 2 Nov 2006 14:41:23 +0000
Subject: [PATCH] [DLM] Fix kref_put oops
This patch fixes the recounting on the lockspace kobject. Previously the lockspace was freed while userspace could have had a reference to one of its sysfs files, causing an oops in kref_put.
Now the lockspace kfree is moved into the kobject release() function
Signed-off-by Patrick Caulfield <[email protected]>
Signed-off-by Steven Whitehouse <[email protected]>
--- fs/dlm/lockspace.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-)
fs/dlm/lockspace.c +8 -1
@@ -143,6 +143,12 @@ static ssize_t dlm_attr_store(struct kobreturn a->store ? a->store (ls, buf, len) : len; } +static void lockspace_kobj_release (struct kobject *k) +{ + struct dlm_ls *ls = container_of(k, struct dlm_ls, ls_kobj); +kfree (ls); +} +static struct sysfs_ops dlm_attr_ops = { .show = dlm_attr_show, .store = dlm_attr_store,
@@ -151,6 +157,7 @@ static struct sysfs_ops dlm_attr_ops = {static struct kobj_type dlm_ktype = { .default_attrs = dlm_attrs, .sysfs_ops = &dlm_attr_ops, + .release = lockspace_kobj_release, };static struct kset dlm_kset = {
@@ -678,7 +685,7 @@ static int release_lockspace(struct dlm_dlm_clear_members_gone (ls);kfree (ls->ls_node_array);kobject_unregister (&ls->ls_kobj); -kfree (ls); +/* The ls structure will be freed when the kobject is done with */ mutex_lock (&ls_lock); ls_count--;
Signature · 1 line
1.4.1