Skip to contentSkip to conversation

client-architecture termination

PATCH In review Jake Moilanen 2 participants 2 messages Nov 8, 2006 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 client-architecture termination

Firmware is crashing during CAS parsing. It appears that a portion of Will's patch got dropped.

	http://patchwork.ozlabs.org/linuxppc/patch?id=6768
 arch/powerpc/kernel/prom_init.c |    1 +
 1 files changed, 1 insertion(+)
arch/powerpc/kernel/prom_init.c +1 -0
Index: 2.6/arch/powerpc/kernel/prom_init.c
===================================================================
@@ -649,6 +649,7 @@ static unsigned char ibm_architecture_ve
 	W(0xfffe0000), W(0x003a0000),	/* POWER5/POWER5+ */
 	W(0xffff0000), W(0x003e0000),	/* POWER6 */
 	W(0xfffffffe), W(0x0f000001),	/* all 2.04-compliant and earlier */
+	W(0x00000000), W(0xffffffff),	/* Terminator-list-entry */
 	5 - 1,				/* 5 option vectors */
 
 	/* option vector 1: processor architectures supported */
#1 lore raw
Quoted 2 lines · Jake Moilanen

Firmware is crashing during CAS parsing. It appears that a portion of Will's patch got dropped.

Indeed it got dropped, because it would make the contents of our ibm_architecture_vec incorrect according to PAPR. The platform architects confirmed some time ago that what we have is correct, and the bug is in firmware - and this was communicated to the firmware developers.

This came up a while ago; I'm surprised that firmware hasn't fixed their bug yet. What firmware level are you seeing this problem with?

Paul.