Skip to contentSkip to conversation

Add dev_sysdata and use it for ACPI

PATCH In review Benjamin Herrenschmidt 1 participant 1 message Nov 10, 2006 Generic include/asm header files

lore
Share & tools
lore
#0 lore raw

cover Add dev_sysdata and use it for ACPI

Due to the total absence of feedback (except Cornelia who'd like to use this for s390 too), I'm reposting them here as they affect all archs (and Willy admitted not seeing them on lkml).

I've already rebased all of my pending 2.6.20 powerpc stuff on top of Patch 1/2, so I hope there won't be any major objection.

Patch 2/2 is not as urgent/important, Len, it's up to you to decide wether you want to take the approach or not, but I feel like this void * firmware_data in struct device is now userless, so ...

1/2 - Add a dev_sysdata structure to struct device whose content is arch specific. It will allow architectures like powerpc, arm, i386, ... who need different types of DMA ops for busses and other kind of auxilliary data for devices in general (numa node id, firmware data, etc...) to put them in there, without bloating all architectures. The patch adds an empty definition for the structure to all architectures.

2/2 - As an example (patch test built but not test booted), I removed ACPI usage of device->firmware_data, removed the firmware_data field completely from struct device (as it was, apparently, the only user), and instead used an "acpi_handle" field in i386, x86_64 and ia64 dev_sysdata.

Cheers,
Ben.