Skip to contentSkip to conversation

ata: sata_highbank: remove superfluous cast

PATCH Applied Bartlomiej Zolnierkiewicz 3 participants 4 messages Mar 26, 2014

Subsystems (2)
libata libata pata arasan compact flash controller
lore
Share & tools
lore

Bartlomiej Zolnierkiewicz

author
#0 lore raw

PATCH 1/1 ata: sata_highbank: remove superfluous cast

hpriv->plat_data is 'void *' so there is no need to cast it to 'struct ecx_plat_data *'.

Cc Mark Langsdorf <[email protected]>
Cc Rob Herring <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
---
 drivers/ata/sata_highbank.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/sata_highbank.c +1 -1
Index: b/drivers/ata/sata_highbank.c
===================================================================
@@ -141,7 +141,7 @@ static ssize_t ecx_transmit_led_message(
 					ssize_t size)
 {
 	struct ahci_host_priv *hpriv =  ap->host->private_data;
-	struct ecx_plat_data *pdata = (struct ecx_plat_data *) hpriv->plat_data;
+	struct ecx_plat_data *pdata = hpriv->plat_data;
 	struct ahci_port_priv *pp = ap->private_data;
 	unsigned long flags;
 	int pmp, i;
#2 lore raw

PATCH 1/1 ata: remove superfluous casts

Unreferenced casts of void * types are unnecessary so remove them.

Signed-off-by Joe Perches <[email protected]>

---

Done with coccinelle

 drivers/ata/libahci.c        | 2 +-
 drivers/ata/pata_arasan_cf.c | 2 +-
 drivers/ata/sata_dwc_460ex.c | 3 +--
 drivers/ata/sata_sx4.c       | 9 +++------
 4 files changed, 6 insertions(+), 10 deletions(-)
drivers/ata/libahci.c +1 -1
index 7985ae7..6bd4f66 100644
@@ -1636,7 +1636,7 @@ static void ahci_error_intr(struct ata_port *ap, u32 irq_stat)
 	}
 
 	if (irq_stat & PORT_IRQ_UNK_FIS) {
-		u32 *unk = (u32 *)(pp->rx_fis + RX_FIS_UNK);
+		u32 *unk = pp->rx_fis + RX_FIS_UNK;
 
 		active_ehi->err_mask |= AC_ERR_HSM;
 		active_ehi->action |= ATA_EH_RESET;
drivers/ata/pata_arasan_cf.c +1 -1
index 73492dd..6fac524 100644
@@ -356,7 +356,7 @@ static void cf_exit(struct arasan_cf_dev *acdev)
 
 static void dma_callback(void *dev)
 {
-	struct arasan_cf_dev *acdev = (struct arasan_cf_dev *) dev;
+	struct arasan_cf_dev *acdev = dev;
 
 	complete(&acdev->dma_completion);
 }
drivers/ata/sata_dwc_460ex.c +1 -2
index 73510d0..0bb2cab 100644
@@ -461,8 +461,7 @@ static irqreturn_t dma_dwc_interrupt(int irq, void *hsdev_instance)
 	int chan;
 	u32 tfr_reg, err_reg;
 	unsigned long flags;
-	struct sata_dwc_device *hsdev =
-		(struct sata_dwc_device *)hsdev_instance;
+	struct sata_dwc_device *hsdev = hsdev_instance;
 	struct ata_host *host = (struct ata_host *)hsdev->host;
 	struct ata_port *ap;
 	struct sata_dwc_device_port *hsdevp;
drivers/ata/sata_sx4.c +3 -6
index 6cd0312..39b5de6 100644
@@ -1020,8 +1020,7 @@ static void pdc20621_get_from_dimm(struct ata_host *host, void *psource,
 	idx++;
 	dist = ((long) (window_size - (offset + size))) >= 0 ? size :
 		(long) (window_size - offset);
-	memcpy_fromio((char *) psource, (char *) (dimm_mmio + offset / 4),
-		      dist);
+	memcpy_fromio(psource, dimm_mmio + offset / 4, dist);
 
 	psource += dist;
 	size -= dist;

@@ -1030,8 +1029,7 @@ static void pdc20621_get_from_dimm(struct ata_host *host, void *psource,
 		readl(mmio + PDC_GENERAL_CTLR);
 		writel(((idx) << page_mask), mmio + PDC_DIMM_WINDOW_CTLR);
 		readl(mmio + PDC_DIMM_WINDOW_CTLR);
-		memcpy_fromio((char *) psource, (char *) (dimm_mmio),
-			      window_size / 4);
+		memcpy_fromio(psource, dimm_mmio, window_size / 4);
 		psource += window_size;
 		size -= window_size;
 		idx++;

@@ -1042,8 +1040,7 @@ static void pdc20621_get_from_dimm(struct ata_host *host, void *psource,
 		readl(mmio + PDC_GENERAL_CTLR);
 		writel(((idx) << page_mask), mmio + PDC_DIMM_WINDOW_CTLR);
 		readl(mmio + PDC_DIMM_WINDOW_CTLR);
-		memcpy_fromio((char *) psource, (char *) (dimm_mmio),
-			      size / 4);
+		memcpy_fromio(psource, dimm_mmio, size / 4);
 	}
 }
 #endif
Applied
#3 lore raw

Re: [PATCH] ata: remove superfluous casts

Quoted 3 lines · Joe Perches

Unreferenced casts of void * types are unnecessary so remove them.

Signed-off-by Joe Perches <[email protected]>

Applied to libata/for-3.15.

Thanks.

Signature · 1 line
tejun