Skip to contentSkip to conversation

various minor manpage fixes

PATCH In review Steinar H. Gunderson 2 participants 4 messages Nov 20, 2006 – Nov 21, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 various minor manpage fixes

Hi,

Here's another patch that has been sitting in our tree for a while, which should probably go in upstream. Changelog:

=== snip ===

Author: Steinar H. Gunderson <[email protected]>
Date:   Mon, 20 Nov 2006 23:46:32 +0100

Use memset instead of __bzero. bzero has been deprecated for years (and anything starting with __ is an internal function anyhow), and __bzero seems to have broken on ia64 not too long ago.
=== snip ===

support/nfs/svc_socket.c +1 -1
diff -ur nfs-utils-1.0.10.orig/support/nfs/svc_socket.c nfs-utils-1.0.10/support/nfs/svc_socket.c
@@ -64,7 +64,7 @@
 	}
     }
 
-  __bzero ((char *) &addr, sizeof (addr));
+  memset (&addr, 0, sizeof (addr));
   addr.sin_family = AF_INET;
 
   ret = getrpcbynumber_r (number, &rpcbuf, rpcdata, sizeof rpcdata,

/* Steinar */

Signature · 10 lines
Homepage: http://www.sesse.net/

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
#1 lore raw
Quoted 2 lines · Steinar H. Gunderson

Here's another patch that has been sitting in our tree for a while, which should probably go in upstream. Changelog:

The subject is wrong, of course; I forgot to fix it when just copying the previous mail. Sorry about that. :-)

/* Steinar */

Signature · 10 lines
Homepage: http://www.sesse.net/

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
#2 lore raw
In reply to Steinar H. Gunderson
Quoted 6 lines · Steinar H. Gunderson

Hi,

Here's another patch that has been sitting in our tree for a while, which should probably go in upstream. Changelog:

=== snip ===

Quoted 8 lines
Author: Steinar H. Gunderson <[email protected]>
Date:   Mon, 20 Nov 2006 23:46:32 +0100

Use memset instead of __bzero. bzero has been deprecated for years (and anything starting with __ is an internal function anyhow), and __bzero seems to have broken on ia64 not too long ago.
=== snip ===

When sending in patches like this, could you please also add in a 'Signed-off-by' line as per the Developer's Certificate of Origin 1.1 (See Documentation/SubmittingPatches in the Linux kernel source). Admittedly the patch you sent in was extremely unlikely to be subject to any special intellectual property claims, but this is a matter of good coding practice.

Cheers
Trond

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#3 lore raw
Quoted 3 lines · Trond Myklebust

When sending in patches like this, could you please also add in a 'Signed-off-by' line as per the Developer's Certificate of Origin 1.1 (See Documentation/SubmittingPatches in the Linux kernel source).

Sure, I'll keep it in mind.

/* Steinar */

Signature · 10 lines
Homepage: http://www.sesse.net/

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs