clear sbflags on lock master [7/9]
Quoted 1 line
From
37019bff80ea5e0115fcf992dec7c936dfbe13c9Mon Sep 17 00:00:00 2001
From: David Teigland <[email protected]>
Date: Fri, 10 Nov 2006 14:16:27 -0600
Subject: [PATCH] [DLM] clear sbflags on lock master
RH BZ 211622
The ALTMODE flag can be set in the lock master's copy of the lock but never cleared, so ALTMODE will also be returned in a subsequent conversion of the lock when it shouldn't be. This results in lock_dlm incorrectly switching to the alternate lock mode when returning the result to gfs which then asserts when it sees the wrong lock state. The fix is to propagate the cleared sbflags value to the master node when the lock is requested. QA's d_rwrandirectlarge test triggers this bug very quickly.
Signed-off-by David Teigland <[email protected]>
Signed-off-by Steven Whitehouse <[email protected]>
--- fs/dlm/lock.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
fs/dlm/lock.c +1 -0
@@ -2372,6 +2372,7 @@ static int send_lookup_reply(struct dlm_static void receive_flags (struct dlm_lkb *lkb,struct dlm_message *ms) { lkb->lkb_exflags = ms->m_exflags; + lkb->lkb_sbflags = ms->m_sbflags; lkb->lkb_flags = (lkb->lkb_flags &0xFFFF0000 ) | (ms->m_flags &0x0000FFFF ); }
Signature · 1 line
1.4.1