Skip to contentSkip to conversation

remove the broken VIDEO_ZR36120 driver

PATCH In review Adrian Bunk 6 participants 10 messages Nov 25, 2006 – Nov 29, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove the broken VIDEO_ZR36120 driver

The VIDEO_ZR36120 driver has:
- already been marked as BROKEN in 2.6.0 three years ago and
- is still marked as BROKEN.

Drivers that had been marked as BROKEN for such a long time seem to be unlikely to be revived in the forseeable future.

But if anyone wants to ever revive this driver, the code is still present in the older kernel releases.

---

This patch was already sent on:
- 18 Nov 2006

Due to it's size, the patch is attached compressed.

 Documentation/video4linux/zr36120.txt |  162 --
 drivers/media/video/Kconfig           |   12 
 drivers/media/video/Makefile          |    2 
 drivers/media/video/zr36120.c         | 2079 --------------------------
 drivers/media/video/zr36120.h         |  279 ---
 drivers/media/video/zr36120_i2c.c     |  132 -
 drivers/media/video/zr36120_mem.c     |   78 
 drivers/media/video/zr36120_mem.h     |    3 
 8 files changed, 2747 deletions(-)
#1 lore raw

Em Sáb, 2006-11-25 às 20:15 +0100, Adrian Bunk escreveu:

Quoted 4 lines

The VIDEO_ZR36120 driver has:
- already been marked as BROKEN in 2.6.0 three years ago and
- is still marked as BROKEN.

Quoted 8 lines

Drivers that had been marked as BROKEN for such a long time seem to be unlikely to be revived in the forseeable future.

But if anyone wants to ever revive this driver, the code is still present in the older kernel releases.

Ok, applied at my -git.

Cheers,
Mauro.

#2 lore raw
In reply to Adrian Bunk

Adrian Bunk wrote on 11/25/06 11:15:

Quoted 9 lines

The VIDEO_ZR36120 driver has:
- already been marked as BROKEN in 2.6.0 three years ago and
- is still marked as BROKEN.

Drivers that had been marked as BROKEN for such a long time seem to be unlikely to be revived in the forseeable future.

But if anyone wants to ever revive this driver, the code is still present in the older kernel releases.

Hmm, there are people out there (like me) who still use it and have patched it to get it working on 2.6.x.

-Joe

#3 lore raw
Quoted 6 lines · Joe Feise

Adrian Bunk wrote on 11/25/06 11:15:

Quoted 4 lines

The VIDEO_ZR36120 driver has:
- already been marked as BROKEN in 2.6.0 three years ago and
- is still marked as BROKEN.

Quoted 8 lines
Quoted 5 lines

Drivers that had been marked as BROKEN for such a long time seem to be unlikely to be revived in the forseeable future.

But if anyone wants to ever revive this driver, the code is still present in the older kernel releases.

Hmm, there are people out there (like me) who still use it and have patched it to get it working on 2.6.x.

If you anyway have to patch your kernel, you can as well patch the complete driver into the kernel.

Three years after 2.6.0 the in-kernel driver is still marked as BROKEN, and e.g. the current Video4Linux API change might leave this driver unfixed and even more broken.

Is anyone working on getting this driver into shape NOW?
If not, it will still be at any time possible to submit a fixed version of this driver for re-inclusion.

Quoted 1 line

-Joe

cu
Adrian

BTW: Please don't drop people from the Cc.

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#4 lore raw

Adrian Bunk wrote on 11/27/06 22:07:

Quoted 10 lines · Joe Feise
Quoted 9 lines

Adrian Bunk wrote on 11/25/06 11:15:

Quoted 7 lines

The VIDEO_ZR36120 driver has:
- already been marked as BROKEN in 2.6.0 three years ago and
- is still marked as BROKEN.

Drivers that had been marked as BROKEN for such a long time seem to be unlikely to be revived in the forseeable future.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

But if anyone wants to ever revive this driver, the code is still present in the older kernel releases.

Hmm, there are people out there (like me) who still use it and have patched it to get it working on 2.6.x.

If you anyway have to patch your kernel, you can as well patch the complete driver into the kernel.

Well, there are other things outside the actual driver code that may change, and that would make it harder to keep my patch in sync.
And actually, I submitted my patch some time ago to the maintainer of the driver (Pauline Middelink.) Unfortunately, it never made it into the kernel, nor did I get any feedback from her. I have no idea if she is still active (she is listed as maintainer at least until 2.6.17.) I cc'ed her on this mail.

-Joe

#5 lore raw

Hi Joe,

Em Seg, 2006-11-27 às 22:36 -0800, Joe Feise escreveu:

Quoted 5 lines

Adrian Bunk wrote on 11/27/06 22:07:

Quoted 3 lines · Joe Feise
Quoted 2 lines

Adrian Bunk wrote on 11/25/06 11:15:

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

But if anyone wants to ever revive this driver, the code is still present in the older kernel releases.

Hmm, there are people out there (like me) who still use it and have patched it to get it working on 2.6.x.

If you anyway have to patch your kernel, you can as well patch the complete driver into the kernel.

Well, there are other things outside the actual driver code that may change, and that would make it harder to keep my patch in sync.

Keeping it in sync is not hard. Most changes are just small API changes that are easy to port to all drivers, since they all behave likely. Also, when kernel hackers changes API, they usually send patches fixing API also at the affected drivers (of course for not-broken stuff).

Quoted 4 lines

And actually, I submitted my patch some time ago to the maintainer of the driver (Pauline Middelink.) Unfortunately, it never made it into the kernel, nor did I get any feedback from her. I have no idea if she is still active (she is listed as maintainer at least until 2.6.17.) I cc'ed her on this mail.

If you are interested on fixing this driver, you may submit the fix patch to me, with your SOB. I'm maintaining the V4L subsystem as a hole.

Quoted 5 lines

-Joe

Cheers,
Mauro.

#6 lore raw
Quoted 24 lines · Mauro Carvalho Chehab

Hi Joe,

Em Seg, 2006-11-27 às 22:36 -0800, Joe Feise escreveu:

Quoted 5 lines

Adrian Bunk wrote on 11/27/06 22:07:

Quoted 3 lines · Joe Feise
Quoted 2 lines

Adrian Bunk wrote on 11/25/06 11:15:

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

But if anyone wants to ever revive this driver, the code is still present in the older kernel releases.

Hmm, there are people out there (like me) who still use it and have patched it to get it working on 2.6.x.

If you anyway have to patch your kernel, you can as well patch the complete driver into the kernel.

Well, there are other things outside the actual driver code that may change, and that would make it harder to keep my patch in sync.

Keeping it in sync is not hard. Most changes are just small API changes that are easy to port to all drivers, since they all behave likely. Also, when kernel hackers changes API, they usually send patches fixing API also at the affected drivers (of course for not-broken stuff).

Quoted 4 lines

And actually, I submitted my patch some time ago to the maintainer of the driver (Pauline Middelink.) Unfortunately, it never made it into the kernel, nor did I get any feedback from her. I have no idea if she is still active (she is listed as maintainer at least until 2.6.17.) I cc'ed her on this mail.

Quoted 8 lines

If you are interested on fixing this driver, you may submit the fix patch to me, with your SOB. I'm maintaining the V4L subsystem as a hole.

Quoted 4 lines

-Joe

Cheers,
Mauro.

Hello,

I would like to see this driver fixed and remaining in the kernel and would give any support I can to achive this goal.

I have a zr36120 based tv card and wrote a driver on my own based on this kernel driver from Pauline Middelink. Maybe it could be helpful.

CU
Peter

#7 lore raw
Quoted 7 lines · Peter Schlaf

Hello,

I would like to see this driver fixed and remaining in the kernel and would give any support I can to achive this goal.

I have a zr36120 based tv card and wrote a driver on my own based on this kernel driver from Pauline Middelink. Maybe it could be helpful.

I would have no problem Peter taking over the maintainance of the driver. Due to timeconstrains I no longer have the time to upgrade the driver to v4l2 (which is a bigger problem than getting the current driver to run under 2.6)

Met vriendelijke groet,
Pauline Middelink

Signature · 2 lines
GPG Key fingerprint = 2D5B 87A7 DDA6 0378 5DEA  BD3B 9A50 B416 E2D0 C3C2
For more details look at my website http://www.polyware.nl/~middelink
#8 lore raw
Quoted 6 lines · Pauline Middelink
Quoted 5 lines · Peter Schlaf

Hello,

I would like to see this driver fixed and remaining in the kernel and would give any support I can to achive this goal.

Quoted 7 lines
Quoted 2 lines

I have a zr36120 based tv card and wrote a driver on my own based on this kernel driver from Pauline Middelink. Maybe it could be helpful.

I would have no problem Peter taking over the maintainance of the driver. Due to timeconstrains I no longer have the time to upgrade the driver to v4l2 (which is a bigger problem than getting the current driver to run under 2.6)

Hi,

I can maintain the driver, if there is no objection.

But this driver only, not the bigphysarea patch.

CU
Peter

#9 lore raw
In reply to Joe Feise
Quoted 2 lines

Hmm, there are people out there (like me) who still use it and have patched it to get it working on 2.6.x.

If the maintainer has vanished can you post the patches here instead for review ?