Skip to contentSkip to conversation

ARM: OMAP: Set keypad sense delays for the Palms.

PATCH In review Andrzej Zaborowski 2 participants 2 messages Nov 26, 2006 – Nov 28, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: OMAP: Set keypad sense delays for the Palms.

Wait a fixed amount of time between writing to the columns register and reading rows state to allow the keypad to respond on Palm Tungsten E and Zire 71. The value for Zire 71 keypad was tested by Marek Vasut.

---
 arch/arm/mach-omap1/board-palmte.c  |    1 +
 arch/arm/mach-omap1/board-palmz71.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/mach-omap1/board-palmte.c +1 -0
index 73e5f50..c23e8b6 100644
@@ -70,6 +70,7 @@ static struct omap_kp_platform_data palm
 	.cols	= 8,
 	.keymap = palmte_keymap,
 	.rep	= 1,
+	.delay	= 12,
 };
 
 static struct resource palmte_kp_resources[] = {
arch/arm/mach-omap1/board-palmz71.c +1 -0
index ebcc6a7..b1ef1be 100644
@@ -76,6 +76,7 @@ static struct omap_kp_platform_data palm
 	.cols	= 8,
 	.keymap	= palmz71_keymap,
 	.rep	= 1,
+	.delay	= 80,
 };
 
 static struct resource palmz71_kp_resources[] = {
Signature · 1 line
1.4.3.2
reviewer
#1 lore raw
Quoted 37 lines · Andrzej Zaborowski

Wait a fixed amount of time between writing to the columns register and reading rows state to allow the keypad to respond on Palm Tungsten E and Zire 71. The value for Zire 71 keypad was tested by Marek Vasut.

---
 arch/arm/mach-omap1/board-palmte.c  |    1 +
 arch/arm/mach-omap1/board-palmz71.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/mach-omap1/board-palmte.c +1 -0
index 73e5f50..c23e8b6 100644
@@ -70,6 +70,7 @@ static struct omap_kp_platform_data palm
 	.cols	= 8,
 	.keymap = palmte_keymap,
 	.rep	= 1,
+	.delay	= 12,
 };
 
 static struct resource palmte_kp_resources[] = {
arch/arm/mach-omap1/board-palmz71.c +1 -0
index ebcc6a7..b1ef1be 100644
@@ -76,6 +76,7 @@ static struct omap_kp_platform_data palm
 	.cols	= 8,
 	.keymap	= palmz71_keymap,
 	.rep	= 1,
+	.delay	= 80,
 };
 
 static struct resource palmz71_kp_resources[] = {
Signature · 1 line
1.4.3.2

Thanks, pushing today.

Tony