Skip to contentSkip to conversation

remove the broken MTD_PCMCIA driver

RFC PATCH In review Adrian Bunk 2 participants 3 messages Nov 18, 2006 – Nov 30, 2006 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 remove the broken MTD_PCMCIA driver

The MTD_PCMCIA driver has:
- already been marked as BROKEN in 2.6.0 three years ago and
- is still marked as BROKEN.

Drivers that had been marked as BROKEN for such a long time seem to be unlikely to be revived in the forseeable future.

But if anyone wants to ever revive this driver, the code is still present in the older kernel releases.

---

 drivers/mtd/maps/Kconfig     |   17 
 drivers/mtd/maps/Makefile    |    1 
 drivers/mtd/maps/pcmciamtd.c |  819 -----------------------------------
 3 files changed, 837 deletions(-)
drivers/mtd/maps/Kconfig renamed from drivers/mtd/maps/Kconfig.old +0 -17
@@ -551,23 +551,6 @@
 
 	  If you are not sure, say N.
 
-config MTD_PCMCIA
-	tristate "PCMCIA MTD driver"
-	depends on MTD && PCMCIA && MTD_COMPLEX_MAPPINGS && BROKEN
-	help
-	  Map driver for accessing PCMCIA linear flash memory cards. These
-	  cards are usually around 4-16MiB in size. This does not include
-	  Compact Flash cards which are treated as IDE devices.
-
-config MTD_PCMCIA_ANONYMOUS
-	bool "Use PCMCIA MTD drivers for anonymous PCMCIA cards"
-	depends on MTD_PCMCIA
-	help
-	  If this option is enabled, PCMCIA cards which do not report
-	  anything about themselves are assumed to be MTD cards.
-
-	  If unsure, say N.
-
 config MTD_UCLINUX
 	tristate "Generic uClinux RAM/ROM filesystem support"
 	depends on MTD_PARTITIONS && !MMU
drivers/mtd/maps/Makefile renamed from drivers/mtd/maps/Makefile.old +0 -1
@@ -27,7 +27,6 @@
 obj-$(CONFIG_MTD_OCTAGON)	+= octagon-5066.o
 obj-$(CONFIG_MTD_PHYSMAP)	+= physmap.o
 obj-$(CONFIG_MTD_PNC2000)	+= pnc2000.o
-obj-$(CONFIG_MTD_PCMCIA)	+= pcmciamtd.o
 obj-$(CONFIG_MTD_RPXLITE)	+= rpxlite.o
 obj-$(CONFIG_MTD_TQM8XXL)	+= tqm8xxl.o
 obj-$(CONFIG_MTD_SA1100)	+= sa1100-flash.o
drivers/mtd/maps/pcmciamtd.c deleted +0 -819

819 lines not on this page · raw message

#1 lore raw
Quoted 6 lines · Adrian Bunk

The MTD_PCMCIA driver has:
- already been marked as BROKEN in 2.6.0 three years ago and
- is still marked as BROKEN.

Drivers that had been marked as BROKEN for such a long time seem to be unlikely to be revived in the forseeable future.

Actually, there's hardware currently on its way to me, and I plan to fix this driver fairly soon.

Quoted 2 lines

But if anyone wants to ever revive this driver, the code is still present in the older kernel releases.

I'm unconvinced by that argument in the general case. People don't go looking back through git history, do they? Drivers such as this don't really do any harm as they are, and they're _much_ easier to find when someone does want to fix them up.

Signature · 1 line
dwmw2
#2 lore raw
Quoted 10 lines · David Woodhouse
Quoted 6 lines · Adrian Bunk

The MTD_PCMCIA driver has:
- already been marked as BROKEN in 2.6.0 three years ago and
- is still marked as BROKEN.

Drivers that had been marked as BROKEN for such a long time seem to be unlikely to be revived in the forseeable future.

Actually, there's hardware currently on its way to me, and I plan to fix this driver fairly soon.

OK.

Quoted 7 lines
Quoted 2 lines

But if anyone wants to ever revive this driver, the code is still present in the older kernel releases.

I'm unconvinced by that argument in the general case. People don't go looking back through git history, do they? Drivers such as this don't really do any harm as they are, and they're _much_ easier to find when someone does want to fix them up.

If there is an already merged driver that is marked as broken for a long time, there are usually two possible cases:
- it is really unused
- patches to fix it are pending or floating around

A patch to remove a driver is usually the best way for getting the information which case a driver belongs into (a good example might be the zr36120 driver that seems to have found a new maintainer due to my removal patch).

And if there's no reaction, the usefullness of very outdated and usually non-compiling code is quite questionable.

Quoted 1 line

dwmw2

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed