Skip to contentSkip to conversation

status messages ping-pong between unmounted nodes [40/70]

DLM Steven Whitehouse 1 participant 1 message Nov 30, 2006 Distributed lock manager (DLM)

lore
Share & tools
lore
#0 lore raw

From 435618b75b82b5ee511cc01fcdda9c44adb2f4bd Mon Sep 17 00:00:00 2001
From: David Teigland <[email protected]>
Date: Thu, 2 Nov 2006 09:45:56 -0600
Subject: [PATCH] [DLM] status messages ping-pong between unmounted nodes

Red Hat BZ 213682

If two nodes leave the lockspace (while unmounting the fs in the case of gfs) after one has sent a STATUS message to the other, STATUS/STATUS_REPLY messages will then ping-pong between the nodes when neither of them can find the lockspace in question any longer. We kill this by not sending another STATUS message when we get a STATUS_REPLY for an unknown lockspace.

---
 fs/dlm/rcom.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
fs/dlm/rcom.c +4 -3
index 518239a..87b12f7 100644
@@ -412,9 +412,10 @@ void dlm_receive_rcom(struct dlm_header 
 
 	ls = dlm_find_lockspace_global(hd->h_lockspace);
 	if (!ls) {
-		log_print("lockspace %x from %d not found",
-			  hd->h_lockspace, nodeid);
-		send_ls_not_ready(nodeid, rc);
+		log_print("lockspace %x from %d type %x not found",
+			  hd->h_lockspace, nodeid, rc->rc_type);
+		if (rc->rc_type == DLM_RCOM_STATUS)
+			send_ls_not_ready(nodeid, rc);
 		return;
 	}
 
Signature · 1 line
1.4.1