Skip to contentSkip to conversation

Fix DLM config [46/70]

DLM Steven Whitehouse 3 participants 3 messages Nov 30, 2006 – Dec 7, 2006 Distributed lock manager (DLM)

lore
Share & tools
lore
#0 lore raw

From b98c95af01c10827e3443157651eb469071391a3 Mon Sep 17 00:00:00 2001
From: Patrick Caulfield <[email protected]>
Date: Wed, 15 Nov 2006 12:29:24 -0500
Subject: [PATCH] [DLM] Fix DLM config

The attached patch fixes the DLM config so that it selects the chosen network transport. It should fix the bug where DLM can be left selected when NET gets unselected. This incorporates all the comments received about this patch.

---
 fs/dlm/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
fs/dlm/Kconfig +2 -1
index c5985b8..b5654a2 100644
@@ -1,10 +1,11 @@
 menu "Distributed Lock Manager"
-	depends on INET && IP_SCTP && EXPERIMENTAL
+	depends on EXPERIMENTAL && INET
 
 config DLM
 	tristate "Distributed Lock Manager (DLM)"
 	depends on IPV6 || IPV6=n
 	select CONFIGFS_FS
+	select IP_SCTP if DLM_SCTP
 	help
 	A general purpose distributed lock manager for kernel or userspace
 	applications.
Signature · 1 line
1.4.1
#1 lore raw
Quoted 18 lines · On Thu, 30 Nov 2006 12:20:42 +0000 Steven Whitehouse wrote:
Quoted 1 line

From b98c95af01c10827e3443157651eb469071391a3 Mon Sep 17 00:00:00 2001

From: Patrick Caulfield <[email protected]>
Date: Wed, 15 Nov 2006 12:29:24 -0500
Subject: [PATCH] [DLM] Fix DLM config

The attached patch fixes the DLM config so that it selects the chosen network transport. It should fix the bug where DLM can be left selected when NET gets unselected. This incorporates all the comments received about this patch.

---
 fs/dlm/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
fs/dlm/Kconfig +0 -0
index c5985b8..b5654a2 100644

fs/dlm/Kconfig line 6

Quoted 7 lines
fs/dlm/Kconfig +1 -1
@@ -1,10 +1,11 @@
 menu "Distributed Lock Manager"
-	depends on INET && IP_SCTP && EXPERIMENTAL
+	depends on EXPERIMENTAL && INET
 
 config DLM
 	tristate "Distributed Lock Manager (DLM)"
 	depends on IPV6 || IPV6=n

What does that "depends on" (above) mean???

fs/dlm/Kconfig line 11

Quoted 6 lines
fs/dlm/Kconfig +1 -0
 	select CONFIGFS_FS
+	select IP_SCTP if DLM_SCTP
 	help
 	A general purpose distributed lock manager for kernel or userspace
 	applications.

Thanks.
---
~Randy

#2 lore raw
Quoted 24 lines · Randy Dunlap
Quoted 22 lines · On Thu, 30 Nov 2006 12:20:42 +0000 Steven Whitehouse wrote:
Quoted 1 line

From b98c95af01c10827e3443157651eb469071391a3 Mon Sep 17 00:00:00 2001

From: Patrick Caulfield <[email protected]>
Date: Wed, 15 Nov 2006 12:29:24 -0500
Subject: [PATCH] [DLM] Fix DLM config

The attached patch fixes the DLM config so that it selects the chosen network transport. It should fix the bug where DLM can be left selected when NET gets unselected. This incorporates all the comments received about this patch.

---
 fs/dlm/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
fs/dlm/Kconfig +1 -1
index c5985b8..b5654a2 100644
@@ -1,10 +1,11 @@
 menu "Distributed Lock Manager"
-	depends on INET && IP_SCTP && EXPERIMENTAL
+	depends on EXPERIMENTAL && INET
 
Quoted 6 lines

fs/dlm/Kconfig line 6

Quoted 3 lines
fs/dlm/Kconfig +0 -0
 config DLM
 	tristate "Distributed Lock Manager (DLM)"
 	depends on IPV6 || IPV6=n

What does that "depends on" (above) mean???
...

It's coming from the select'ed IP_SCTP:

SCTP has optional IPV6 support, and this handles IPV6=m, IP_SCTP=y by making it an illegal configuration.

Quoted 2 lines

Thanks.
~Randy

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed