Skip to contentSkip to conversation

VMSPLIT_2G conflicts with PAE

PATCH In review Shaohua Li 4 participants 5 messages Dec 1, 2006 – Dec 2, 2006

lore
Share & tools
lore

Shaohua Li

author
#0 lore raw

PATCH 1/1 VMSPLIT_2G conflicts with PAE

PAGE_OFFSET is 0x78000000 with VMSPLIT_2G, this address is in the middle of the second pgd entry with pae enabled. This breaks assumptions (address is aligned to pgd entry's address) in a lot of places like pagetable_init. Fixing the assumptions is hard (eg, low mapping). SO I just changed the address to 0x80000000.

arch/i386/Kconfig +1 -1
index 8ff1c6f..fddfb26 100644
@@ -532,7 +532,7 @@ endchoice
 config PAGE_OFFSET
 	hex
 	default 0xB0000000 if VMSPLIT_3G_OPT
-	default 0x78000000 if VMSPLIT_2G
+	default 0x80000000 if VMSPLIT_2G
 	default 0x40000000 if VMSPLIT_1G
 	default 0xC0000000
 
#1 lore raw
Quoted 13 lines · Shaohua Li

PAGE_OFFSET is 0x78000000 with VMSPLIT_2G, this address is in the middle of the second pgd entry with pae enabled. This breaks assumptions (address is aligned to pgd entry's address) in a lot of places like pagetable_init. Fixing the assumptions is hard (eg, low mapping). SO I just changed the address to 0x80000000.

arch/i386/Kconfig +0 -0
index 8ff1c6f..fddfb26 100644

arch/i386/Kconfig endchoice · line 537

Quoted 7 lines
arch/i386/Kconfig +1 -1
@@ -532,7 +532,7 @@ endchoice
 config PAGE_OFFSET
 	hex
 	default 0xB0000000 if VMSPLIT_3G_OPT
-	default 0x78000000 if VMSPLIT_2G
+	default 0x80000000 if VMSPLIT_2G
 	default 0x40000000 if VMSPLIT_1G
 	default 0xC0000000

0x78000000 was chosen since it gives you the full 2G as low memory, if you mave it 0x80000000 then you still have a little highmem and need that turned on.

Signature · 1 line
Jens Axboe
author
#2 lore raw
Quoted 9 lines · Jens Axboe
Quoted 8 lines · Shaohua Li

PAGE_OFFSET is 0x78000000 with VMSPLIT_2G, this address is in the middle of the second pgd entry with pae enabled. This breaks assumptions (address is aligned to pgd entry's address) in a lot of places like pagetable_init. Fixing the assumptions is hard (eg, low mapping). SO I just changed the address to 0x80000000.

Quoted 16 lines

arch/i386/Kconfig endchoice · line 537

Quoted 12 lines
arch/i386/Kconfig +1 -1
index 8ff1c6f..fddfb26 100644
@@ -532,7 +532,7 @@ endchoice
 config PAGE_OFFSET
 	hex
 	default 0xB0000000 if VMSPLIT_3G_OPT
-	default 0x78000000 if VMSPLIT_2G
+	default 0x80000000 if VMSPLIT_2G
 	default 0x40000000 if VMSPLIT_1G
 	default 0xC0000000

0x78000000 was chosen since it gives you the full 2G as low memory, if you mave it 0x80000000 then you still have a little highmem and need that turned on.

Ok, Maybe the x86 relocatable patch (it seems removed the low identity mapping) can help here. With it, we just need to fix pagetable_init.

Thanks,
Shaohua

#3 lore raw
In reply to Shaohua Li

Hi!

Quoted 13 lines

PAGE_OFFSET is 0x78000000 with VMSPLIT_2G, this address is in the middle of the second pgd entry with pae enabled. This breaks assumptions (address is aligned to pgd entry's address) in a lot of places like pagetable_init. Fixing the assumptions is hard (eg, low mapping). SO I just changed the address to 0x80000000.

arch/i386/Kconfig +0 -0
index 8ff1c6f..fddfb26 100644

arch/i386/Kconfig endchoice · line 537

Quoted 7 lines
arch/i386/Kconfig +1 -1
@@ -532,7 +532,7 @@ endchoice
 config PAGE_OFFSET
 	hex
 	default 0xB0000000 if VMSPLIT_3G_OPT
-	default 0x78000000 if VMSPLIT_2G
+	default 0x80000000 if VMSPLIT_2G
 	default 0x40000000 if VMSPLIT_1G
 	default 0xC0000000

Do we allow user entering arbitrary value here? In any case, it would be nice to document alignment requirements of this one, because otherwise someone *will* get it wrong.

Signature · 1 line
Thanks for all the (sleeping) penguins.
#4 lore raw
Quoted 10 lines
Quoted 6 lines

PAGE_OFFSET is 0x78000000 with VMSPLIT_2G, this address is in the middle of the second pgd entry with pae enabled. This breaks assumptions (address is aligned to pgd entry's address) in a lot of places like pagetable_init. Fixing the assumptions is hard (eg, low mapping). SO I just changed the address to 0x80000000.

Do we allow user entering arbitrary value here? In any case, it would be nice to document alignment requirements of this one, because otherwise someone *will* get it wrong.

There was a reason 0x78000000 was chosen
http://marc.theaimsgroup.com/?l=linux-kernel&m=113690073801820&w=2

Though further back in
http://marc.theaimsgroup.com/?l=linux-kernel&m=113689790817521&w=2
0x80000000 was indeed posted.

	-`J'