Skip to contentSkip to conversation

soc/rockchip: Restrict to ARCH_ROCKCHIP

PATCH New Thierry Reding 2 participants 2 messages Oct 9, 2015 – Oct 11, 2015 Arm Rockchip

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc/rockchip: Restrict to ARCH_ROCKCHIP

From: Thierry Reding <[email protected]>

By definition this directory contains drivers that are specific to the Rockchip architecture. All Kconfig options should therefore depend on ARCH_ROCKCHIP to avoid exposing these symbols on other architectures. For example, this options currently shows up as new when doing an incremental build on PowerPC.

---
 drivers/soc/rockchip/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)
drivers/soc/rockchip/Kconfig +4 -0
index 6ee03994801c..d09b5ede7deb 100644
@@ -1,3 +1,5 @@
+if ARCH_ROCKCHIP
+
 #
 # Rockchip Soc drivers
 #
@@ -12,3 +14,5 @@ config ROCKCHIP_PM_DOMAINS
           mode. The RK3288 PMU is dedicated for managing the power of the whole chip.
 
           If unsure, say N.
+
+endif
Signature · 1 line
2.5.0
maintainer
#1 lore raw

PATCH 1/1 soc/rockchip: Restrict to ARCH_ROCKCHIP

Hi Thierry,

Am Freitag, 9. Oktober 2015, 15:46:18 schrieb Thierry Reding:

Quoted 9 lines

From: Thierry Reding <[email protected]>

By definition this directory contains drivers that are specific to the Rockchip architecture. All Kconfig options should therefore depend on ARCH_ROCKCHIP to avoid exposing these symbols on other architectures. For example, this options currently shows up as new when doing an incremental build on PowerPC.

thanks for catching this and I agree that Rockchip stuff should not leak into other arches :-) .

I've applied this after adding a "|| COMPILE_TEST" alternative to the condition.

Thanks
Heiko