Skip to contentSkip to conversation

Recent changes in xfsprogs

DISCUSSION Nathan Scott 3 participants 4 messages Dec 5, 2006 – Dec 6, 2006

lore
Share & tools
lore
#0 lore raw

Yo Barry,

xfsprogs/doc/CHANGES

- Rename include/list.h to xfs_list.h so that other applications do not accidentally use it.

What was the problem here? This doesnt sound like the right fix - there should be no applications outside of the XFS userspace that use libxfs.h - thats what <xfs/xfs.h> is for (exactly this reason, preventing namespace collision, by reducing all the XFS internals being exposed).

Also, there seems to be lots of checkin mail not making it out to oss.sgi.com (let alone review mail), making it difficult for people to keep up to date with changes (and keep distros, like Debian, uptodate) ... could y'all make some effort to keep us "on the outside" in the loop?

Oh, noone is updating oss.sgi.com/projects/xfs/{news,index}.html with recent changes either - seems like progress has come to a halt to those of us no longer in the secret cabal, anyway ;) ... just FYI.

cheers.

Signature · 1 line
Nathan
#1 lore raw

Nathan,

Quoted 4 lines · Nathan Scott

Yo Barry,

xfsprogs/doc/CHANGES

Quoted 9 lines

- Rename include/list.h to xfs_list.h so that other applications do not accidentally use it.

What was the problem here? This doesnt sound like the right fix - there should be no applications outside of the XFS userspace that use libxfs.h - thats what <xfs/xfs.h> is for (exactly this reason, preventing namespace collision, by reducing all the XFS internals being exposed).

A classic problem with cpp is that it is possible for someone else to introduce a header that breaks your build. By introducing a header called list.h, a very common name, we have exposed products whose build may not have strictly doing the right thing (adding /usr/include/xfs to their include path) to pulling in this file rather than the one they intended.

So strictly speaking XFS was doing nothing wrong, but its a simple change for us to make to be more friendly. The application that had this problem has also been fixed to use <xfs/foo.h>.

Quoted 6 lines

Also, there seems to be lots of checkin mail not making it out to oss.sgi.com (let alone review mail), making it difficult for people to keep up to date with changes (and keep distros, like Debian, uptodate) ... could y'all make some effort to keep us "on the outside" in the loop?

True, not everything has been escaping of late.

Quoted 5 lines

Oh, noone is updating oss.sgi.com/projects/xfs/{news,index}.html with recent changes either - seems like progress has come to a halt to those of us no longer in the secret cabal, anyway ;) ... just FYI.

Its now on my list of things to do.

David

Signature · 3 lines
David Chatterton
XFS Engineering Manager
SGI Australia
#2 lore raw
Quoted 3 lines · David Chatterton

...
A classic problem with cpp is that it is possible for someone else to introduce a header that breaks your build.

Heh, its a poor tradesman who blames his tools. :)

Quoted 5 lines

By introducing a header
called list.h, a very common name, we have exposed products whose build may not have strictly doing the right thing (adding /usr/include/xfs to their include path) to pulling in this file rather than the one they intended.

Well, clearly they're doing the wrong thing. We've now introduced a half-baked scheme where one random header is inconsistent with the rest, because of some other broken application. That's dopey.

The convention there now is such that its easy to tell what include/ files have kernel counterparts (the xfs_* prefixed ones), and the rest are generically named (list.h, cache.h, parent.h, paths.h, linux.h, etc). This change now makes list.h sit in no-mans-land... please revert it back, since the app is fixed anyway (you are also, of course, ignoring the flip side of your own argument, which is that other equally broken apps could be using <xfs/list.h>, which moved and hence broke their builds). You can't win by pandering to broken 3rd party applications... best you can do is keep the XFS stuff sane and internally consistent.

Quoted 8 lines
Quoted 5 lines

Oh, noone is updating oss.sgi.com/projects/xfs/{news,index}.html with recent changes either - seems like progress has come to a halt to those of us no longer in the secret cabal, anyway ;) ... just FYI.

Its now on my list of things to do.

Great - thanks!

cheers.

Signature · 1 line
Nathan
#3 lore raw
In reply to Nathan Scott
Quoted 5 lines · Nathan Scott

Also, there seems to be lots of checkin mail not making it out to oss.sgi.com (let alone review mail), making it difficult for people to keep up to date with changes (and keep distros, like Debian, uptodate) ... could y'all make some effort to keep us "on the outside" in the loop?

here here! :)

-Eric