sata_svw: Check for errors from ata_device_add()
PATCH 1/1 sata_svw: Check for errors from ata_device_add()
Without this patch, G5 oopses on boot. I've had this in Ubuntu since 2.6.17, but I forgot it was in there. Still required with 2.6.20.
Signed-off-by Ben Collins <[email protected]>
drivers/ata/sata_svw.c +4 -4
@@ -473,11 +473,11 @@ static int k2_sata_init_one (struct pci_pci_set_master (pdev); -/* FIXME: check ata_device_add return value */ -ata_device_add (probe_ent); -kfree (probe_ent); +if (ata_device_add (probe_ent)) +return 0 ; -return 0 ; +/* Failed to add, no device present */ + rc = -ENODEV ; err_out_free_ent:kfree (probe_ent);
Quoted 4 lines · Ben Collins
Without this patch, G5 oopses on boot. I've had this in Ubuntu since 2.6.17, but I forgot it was in there. Still required with 2.6.20.
Signed-off-by Ben Collins <[email protected]>
Ignore this patch for now, BenH and I are discussing the issue further.