Skip to contentSkip to conversation

kbuild: move tags from ARCH and include/ ahead of drivers

PATCH Applied Don Mullis 2 participants 2 messages Jan 4, 2007 – Mar 17, 2007 Kbuild

lore
Share & tools
lore

Don Mullis

author
#0 lore raw

PATCH 1/1 kbuild: move tags from ARCH and include/ ahead of drivers

Move tags extracted from the ARCH and include/ sub-trees ahead of those from device drivers, so that the former will appear first during searches.

Saves user time during interactive searches for certain patterns that happen to find unwanted matches in driver files.

Example in emacs:
"M-x find-tag PAGE_SIZE"
"M-1 M-." (repeated until definition from asm-i386/page.h appears)

---
Tested with emacs/etags/ctags v22.0.92 by:
1) running make TAGS, make tags with and without patch (ARCH=i386).
2) verifying improved behavior of tag definition searching with "M-x find-tag PAGE_SIZE", "M-1 M-." in emacs

 Makefile |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
Makefile +6 -5
Index: linux-2.6.19/Makefile
===================================================================
@@ -1292,10 +1292,7 @@ endif
 ALLSOURCE_ARCHS := $(ARCH)
 
 define find-sources
-        ( find $(__srctree) $(RCS_FIND_IGNORE) \
-	       \( -name include -o -name arch \) -prune -o \
-	       -name $1 -print; \
-	  for ARCH in $(ALLSOURCE_ARCHS) ; do \
+        ( for ARCH in $(ALLSOURCE_ARCHS) ; do \
 	       find $(__srctree)arch/$${ARCH} $(RCS_FIND_IGNORE) \
 	            -name $1 -print; \
 	  done ; \
@@ -1309,7 +1306,11 @@ define find-sources
 	            -name $1 -print; \
 	  done ; \
 	  find $(__srctree)include/asm-generic $(RCS_FIND_IGNORE) \
-	       -name $1 -print )
+	       -name $1 -print; \
+	  find $(__srctree) $(RCS_FIND_IGNORE) \
+	       \( -name include -o -name arch \) -prune -o \
+	       -name $1 -print; \
+	  )
 endef
 
 define all-sources
Applied
#1 lore raw
Quoted 4 lines · Don Mullis

Move tags extracted from the ARCH and include/ sub-trees ahead of those from device drivers, so that the former will appear first during searches.

Quoted 8 lines

Saves user time during interactive searches for certain patterns that happen to find unwanted matches in driver files.

Example in emacs:
"M-x find-tag PAGE_SIZE"
"M-1 M-." (repeated until definition from asm-i386/page.h appears)

Applied, thanks.

Sam