Skip to contentSkip to conversation

Make omap_bl build again after API change.

PATCH In review Andrzej Zaborowski 2 participants 2 messages Jan 5, 2007 – Jan 9, 2007

Subsystems (2)
Framebuffer layer Backlight class/subsystem
lore
Share & tools
lore

Andrzej Zaborowski

author
#0 lore raw

PATCH 1/1 Make omap_bl build again after API change.

[Oops, I sent this to Dirk eariler and forgot to CC the list.] Make omap_bl build again after API change.

Breakage spotted by Dirk Behme.
Also remove comment about API glitch which has just been fixed.

Signed-off-by Andrzej Zaborowski <[email protected]>
---
 drivers/video/backlight/omap_bl.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)
drivers/video/backlight/omap_bl.c +2 -6
index 22189b1..3b57b27 100644
@@ -152,12 +152,8 @@ static int omapbl_probe(struct platform_
 	if (unlikely(!bl))
 		return -ENOMEM;
 
-	/* REVISIT backlight API glitch:  we can't associate the
-	 * class device with "pdev" ... probably pass &pdev->dev
-	 * instead of a string.
-	 */
-
-	dev = backlight_device_register("omap-bl", bl, &omapbl_data);
+	dev = backlight_device_register("omap-bl", &pdev->dev,
+			bl, &omapbl_data);
 	if (IS_ERR(dev)) {
 		kfree(bl);
 		return PTR_ERR(dev);
Signature · 1 line
1.4.3.2
#1 lore raw
Quoted 20 lines · Andrzej Zaborowski

[Oops, I sent this to Dirk eariler and forgot to CC the list.] Make omap_bl build again after API change.

Breakage spotted by Dirk Behme.
Also remove comment about API glitch which has just been fixed.

Signed-off-by Andrzej Zaborowski <[email protected]>
---
 drivers/video/backlight/omap_bl.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)
drivers/video/backlight/omap_bl.c +0 -1
index 22189b1..3b57b27 100644
@@ -152,12 +152,8 @@ static int omapbl_probe(struct platform_
 	if (unlikely(!bl))
 		return -ENOMEM;
 
-	/* REVISIT backlight API glitch:  we can't associate the

drivers/video/backlight/omap_bl.c static int omapbl_probe(struct platform_ · line 159

Quoted 10 lines
drivers/video/backlight/omap_bl.c +2 -5
-	 * class device with "pdev" ... probably pass &pdev->dev
-	 * instead of a string.
-	 */
-
-	dev = backlight_device_register("omap-bl", bl, &omapbl_data);
+	dev = backlight_device_register("omap-bl", &pdev->dev,
+			bl, &omapbl_data);
 	if (IS_ERR(dev)) {
 		kfree(bl);
 		return PTR_ERR(dev);

Pushing today.

Tony