Skip to contentSkip to conversation

Run tests with managed domains and fix of a bug related to 'xm domid'

PATCH Applied Stefan Berger 2 participants 2 messages Jan 10, 2007 – Jan 11, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Run tests with managed domains and fix of a bug related to 'xm domid'

I added a parameter '-md' to 'runtest.sh' for running the xm test suite in a mode where all created domains a created as xend-managed domains.

This patch also fixes a problem related to calling 'xm domid' on a currently suspended domain if that domain is a managed domain. In that case a 'None' is returned by Xend, which I default to '-1'.

xen-unstable.hg/tools/xm-test/runtest.sh +8 -0
Index: root/xen-unstable.hg/tools/xm-test/runtest.sh
===================================================================
@@ -16,6 +16,7 @@ usage() {
     echo "  -r <url>    : url of test results repository to use"
     echo "  -s <report> : just submit report <report>"
     echo "  -u          : unsafe -- do not run the sanity checks before starting"
+    echo "  -md         : all created domains are xend-'managed' domains"
     echo "  -h | --help : show this help"
 }
 
@@ -218,11 +219,14 @@ run=yes
 unsafe=no
 GROUPENTERED=default
 
+#Prepare for usage with ACM
 if [ -d /etc/xen/acm-security/policies ]; then
 	cp -f tests/security-acm/xm-test-security_policy.xml \
 	      /etc/xen/acm-security/policies
 fi
 
+unset XM_MANAGED_DOMAINS
+
 # Resolve options
 while [ $# -gt 0 ]
   do
@@ -260,6 +264,10 @@ while [ $# -gt 0 ]
 	  unsafe=yes
 	  report=no
 	  ;;
+      -md)
+          echo "(use managed domains)"
+          export XM_MANAGED_DOMAINS=1
+          ;;
       -h|--help)
           usage
           exit 0
xen-unstable.hg/tools/xm-test/lib/XmTestLib/Xm.py +2 -0
Index: root/xen-unstable.hg/tools/xm-test/lib/XmTestLib/Xm.py
===================================================================
@@ -49,6 +49,8 @@ def domid(name):
 
     if status != 0 or "Traceback" in output:
         return -1
+    if output == "None":
+        return -1
     try:
         return int(output)
     except:

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Applied
#1 lore raw
Quoted 8 lines · Stefan Berger

I added a parameter '-md' to 'runtest.sh' for running the xm test suite in a mode where all created domains a created as xend-managed domains.

This patch also fixes a problem related to calling 'xm domid' on a currently suspended domain if that domain is a managed domain. In that case a 'None' is returned by Xend, which I default to '-1'.

Applied, thanks.

Ewan.