Fix missing include of list.h in sysfs.h
PATCH 1/1 Fix missing include of list.h in sysfs.h
Sysfs.h uses definitions (e.g. struct list_head s_sibling) from list.h but does not include it.
--- include/linux/sysfs.h | 1 + 1 file changed, 1 insertion(+)
include/linux/sysfs.h +1 -0
@@ -11,6 +11,7 @@#define _SYSFS_H_#include <linux/compiler.h> +#include <linux/list.h> #include <asm/atomic.h> struct kobject ;
Quoted 11 lines · Frank Haverkamp
Sysfs.huses definitions (e.g. structlist_heads_sibling) fromlist.hbut does not include it.Signed-off-by Frank Haverkamp <[email protected]>--- include/linux/sysfs.h | 1 + 1 file changed, 1 insertion(+)
include/linux/sysfs.h line 15
Quoted 5 lines
include/linux/sysfs.h +1
-0@@ -11,6 +11,7 @@#define _SYSFS_H_#include <linux/compiler.h> +#include <linux/list.h> #include <asm/atomic.h>
Does this currently cause a build error on any platform for 2.6.20-rc5?
thanks,
greg k-h
Hi Greg,
Quoted 1 line · Greg KH
Does this currently cause a build error on any platform for 2.6.20-rc5?
Not that I know of. I saw it because a friend of mine tried to port some old code and played with the include ordering. Somehow he got a compile error doing it, and we found that it is strange that sysfs.h is using structs from list.h but is not including it. As result I sent the patch to propose that it gets included to avoid any possible trouble.
Frank