SATA exceptions with 2.6.20-rc5
Hi,
I went from 2.6.19+sata_nv-adma-ncq-v7.patch, with no problems and adama enabled, to 2.6.20-rc5, which gave me problems almost instantly.
I just thought that it might be interesting to know that it DID work nicely.
CC since i'm not on the ml
Signature · 1 line
Ian Kumlien <pomac () vapor ! com> -- http://pomac.netswarm.net
Quoted 10 lines · Ian Kumlien
Hi,
I went from 2.6.19+sata_nv-adma-ncq-v7.patch, with no problems and adama enabled, to 2.6.20-rc5, which gave me problems almost instantly.
I just thought that it might be interesting to know that it DID work nicely.
CC since i'm not on the ml
(I'm ccing more of the people who reported this)
Well that's interesting.. The only significant change that went into 2.6.20-rc5 in that driver that wasn't in that version you mentioned was this one:
Could you (or anyone else) test what happens if you take the 2.6.20-rc5 version of sata_nv.c and try it on 2.6.19? That would tell us whether it's this change or whether it's something else (i.e. in libata core).
Assuming that still doesn't work, can you then try removing these lines from nv_host_intr in 2.6.20-rc5 sata_nv.c and see what that does?
/* bail out if not our interrupt */ if (!(irq_stat & NV_INT_DEV)) return 0;
as that's the difference I'm most suspicious of causing the problem.
Signature · 3 lines
Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from [email protected] Home Page: http://www.roberthancock.com/
Quoted 17 lines · Robert Hancock
Quoted 9 lines · Ian Kumlien
Hi,
I went from 2.6.19+sata_nv-adma-ncq-v7.patch, with no problems and adama enabled, to 2.6.20-rc5, which gave me problems almost instantly.
I just thought that it might be interesting to know that it DID work nicely.
CC since i'm not on the ml
(I'm ccing more of the people who reported this)
Well that's interesting.. The only significant change that went into 2.6.20-rc5 in that driver that wasn't in that version you mentioned was this one:
Quoted 6 lines
http://www2.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=com
mit;h=2dec7555e6bf2772749113ea0ad454fcdb8cf861Could you (or anyone else) test what happens if you take the 2.6.20-rc5 version of
sata_nv.cand try it on 2.6.19? That would tell us whether it's this change or whether it's something else (i.e. in libata core).
I'm still running an -rc5 kernel with ADMA switched off entirely and I can't reproduce the problem. How is everybody else reproducing this?
I've been successful installing bonnie++, then going to a large XFS partition and running "bonnie++ -u 1000:1000" and letting it run through, all defaults.
It doesn't cause the problem I was seeing in -rc5 with ADMA on, when I switch ADMA off, so I think this is sufficient to fix it.
Others have reported differently. Did you guys do:
alistair@damocles:~$ cat /proc/cmdline root=/dev/sda1 ro sata_nv.adma=0
Or something similar? This is how Jeff suggested disabling ADMA and indeed the messages about its use disappear from dmesg.
Signature · 5 lines
Cheers, Alistair. Final year Computer Science undergraduate. 1F2 55 South Clerk Street, Edinburgh, UK.
Quoted 25 lines · Alistair John Strachan
Quoted 17 lines · Robert Hancock
Quoted 9 lines · Ian Kumlien
Hi,
I went from 2.6.19+sata_nv-adma-ncq-v7.patch, with no problems and adama enabled, to 2.6.20-rc5, which gave me problems almost instantly.
I just thought that it might be interesting to know that it DID work nicely.
CC since i'm not on the ml
(I'm ccing more of the people who reported this)
Well that's interesting.. The only significant change that went into 2.6.20-rc5 in that driver that wasn't in that version you mentioned was this one:
Quoted 6 lines
http://www2.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=com
mit;h=2dec7555e6bf2772749113ea0ad454fcdb8cf861Could you (or anyone else) test what happens if you take the 2.6.20-rc5 version of
sata_nv.cand try it on 2.6.19? That would tell us whether it's this change or whether it's something else (i.e. in libata core).
Quoted 8 lines
I'm still running an -rc5 kernel with ADMA switched off entirely and I can't reproduce the problem. How is everybody else reproducing this?
I've been successful installing bonnie++, then going to a large XFS partition and running "bonnie++ -u 1000:1000" and letting it run through, all defaults.
It doesn't cause the problem I was seeing in -rc5 with ADMA on, when I switch ADMA off, so I think this is sufficient to fix it.
Eh? The whole point with that patch was to ADD ADMA support to sata_nv, imho that is something we want to have and i have been running with ADMA on on two computers since sata_nv-adma-ncq-v4 or 5 or so without problems.
So, something has been introduced or been broken to cause this error, wouldn't it be better to find the error introduced than to just totally negate the patch in the first place?
I haven't had the energy to go trough the patch that was found as causing the problem yet... I don't know if i even have all the info needed to make any form of educated guess but i'll give it a try when i have the energy.
I really home someone finds it before then =)
Signature · 1 line
Ian Kumlien <pomac () vapor ! com> -- http://pomac.netswarm.net