Skip to contentSkip to conversation

d80211: configure hardware when the interface is brought up

PATCH New Pavel Roskin 1 participant 1 message Jan 26, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 d80211: configure hardware when the interface is brought up

ieee80211_hw_config() is called from scanning functions and ioctl handlers, but not when the interface is brought up. This is unreasonable. Since the config function is provided by hardware drivers to d80211, the later should be responsible for calling it in all situations when the hardware needs to be reconfigured.

Without this patch, bcm43xx_d80211 needs the channel to be set again after the interface goes down and up. Similar problems are reported for rt2x00 drivers.

Failure in ieee80211_hw_config() leads to the interface staying down.

---

 net/d80211/ieee80211.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
net/d80211/ieee80211.c +2 -0
index 2f1dce5..7219416 100644
@@ -2239,6 +2239,8 @@ static int ieee80211_open(struct net_device *dev)
 		res = 0;
 		if (local->ops->open)
 			res = local->ops->open(local_to_hw(local));
+		if (res == 0)
+			res = ieee80211_hw_config(local);
 		if (res == 0) {
 			res = dev_open(local->mdev);
 			if (res) {
Signature · 2 lines
Regards,
Pavel Roskin