Skip to contentSkip to conversation

input: Schedule removal of compaq touchscreen emulation (tsdev.c)

PATCH In review Richard Purdie 4 participants 5 messages Feb 6, 2007 – Feb 7, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 input: Schedule removal of compaq touchscreen emulation (tsdev.c)

Schedule removal of Compaq touchscreen emulation (drivers/input/tsdev.c)

Its old, was obsolete when it was written by the authors own admission and much better userspace solutions like tslib now exist. The name is also confusing.

 Documentation/feature-removal-schedule.txt |   14 ++++++++++++++
 1 file changed, 14 insertions(+)
Documentation/feature-removal-schedule.txt +14 -0
Index: linux/Documentation/feature-removal-schedule.txt
===================================================================
@@ -325,3 +325,17 @@ Why:	Unmaintained for years, superceded 
 Who:	Jeff Garzik <[email protected]>
 
 ---------------------------
+
+What:   Compaq touchscreen device emulation
+When:   Oct 2007
+Files:  drivers/input/tsdev.c
+Why:    The code says it was obsolete when it was written in 2001.
+        tslib is a userspace library which does anything tsdev can do and
+        much more besides in userspace where this code belongs. There is no
+        longer any need for tsdev and applications should have converted to
+        use tslib by now.
+        The name "tsdev" is also extremely confusing and lots of people have
+        it loaded when they don't need/use it.
+Who:    Richard Purdie <[email protected]>
+
+---------------------------
Acked-by on v1 1/1
#1 lore raw

My old driver. Yes please kill it.

Quoted 41 lines · Richard Purdie

Schedule removal of Compaq touchscreen emulation (drivers/input/tsdev.c)

Its old, was obsolete when it was written by the authors own admission and much better userspace solutions like tslib now exist. The name is also confusing.

 Documentation/feature-removal-schedule.txt |   14 ++++++++++++++
 1 file changed, 14 insertions(+)

Index: linux/Documentation/feature-removal-schedule.txt
===================================================================

Documentation/feature-removal-schedule.txt +14 -1
@@ -325,3 +325,17 @@ Why:	Unmaintained for years, superceded 
 Who:	Jeff Garzik <[email protected]>
 
 ---------------------------
+
+What:   Compaq touchscreen device emulation
+When:   Oct 2007
+Files:  drivers/input/tsdev.c
+Why:    The code says it was obsolete when it was written in 2001.
+        tslib is a userspace library which does anything tsdev can do and
+        much more besides in userspace where this code belongs. There is no
+        longer any need for tsdev and applications should have converted to
+        use tslib by now.
+        The name "tsdev" is also extremely confusing and lots of people have
+        it loaded when they don't need/use it.
+Who:    Richard Purdie <[email protected]>
+
+---------------------------
 
 
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
In reply to Richard Purdie

Documentation/feature-removal-schedule.txt Why: Unmaintained for years, superceded · line 339

Quoted 13 lines · On Tue, 06 Feb 2007 16:42:39 +0000 Richard Purdie <[email protected]> wrote:

---------------------------

Documentation/feature-removal-schedule.txt +12 -0
+
+What:   Compaq touchscreen device emulation
+When:   Oct 2007
+Files:  drivers/input/tsdev.c
+Why:    The code says it was obsolete when it was written in 2001.
+        tslib is a userspace library which does anything tsdev can do and
+        much more besides in userspace where this code belongs. There is no
+        longer any need for tsdev and applications should have converted to
+        use tslib by now.
+        The name "tsdev" is also extremely confusing and lots of people have
+        it loaded when they don't need/use it.
+Who:    Richard Purdie <[email protected]>

I think it best to add a printk to the driver's initialisation routine warning any remaining users that it is going away.

author Acked-by James Simmons
#3 lore raw
Quoted 18 lines · Andrew Morton

Review

Quoted 13 lines · On Tue, 06 Feb 2007 16:42:39 +0000 Richard Purdie <[email protected]> wrote:

---------------------------

(quoted diff) +12 -0
+
+What:   Compaq touchscreen device emulation
+When:   Oct 2007
+Files:  drivers/input/tsdev.c
+Why:    The code says it was obsolete when it was written in 2001.
+        tslib is a userspace library which does anything tsdev can do and
+        much more besides in userspace where this code belongs. There is no
+        longer any need for tsdev and applications should have converted to
+        use tslib by now.
+        The name "tsdev" is also extremely confusing and lots of people have
+        it loaded when they don't need/use it.
+Who:    Richard Purdie <[email protected]>

I think it best to add a printk to the driver's initialisation routine warning any remaining users that it is going away.

I suspect a message upon driver init will scare a lot of people due to the "lots of people have it loaded when they don't need/use it" above. How about printing something upon device open? A revised version is below.

----

Schedule removal of Compaq touchscreen emulation (drivers/input/tsdev.c)

Its old, was obsolete when it was written by the authors own admission and much better userspace solutions like tslib now exist. The name is also confusing.

---

 Documentation/feature-removal-schedule.txt |   14 ++++++++++++++
 drivers/input/tsdev.c                      |    4 ++++
 2 files changed, 18 insertions(+)
Documentation/feature-removal-schedule.txt +14 -0
Index: linux/Documentation/feature-removal-schedule.txt
===================================================================
@@ -325,3 +325,17 @@ Why:	Unmaintained for years, superceded 
 Who:	Jeff Garzik <[email protected]>
 
 ---------------------------
+
+What:   Compaq touchscreen device emulation
+When:   Oct 2007
+Files:  drivers/input/tsdev.c
+Why:    The code says it was obsolete when it was written in 2001.
+        tslib is a userspace library which does anything tsdev can do and
+	much more besides in userspace where this code belongs. There is no
+	longer any need for tsdev and applications should have converted to
+	use tslib by now.
+        The name "tsdev" is also extremely confusing and lots of people have
+	it loaded when they don't need/use it.
+Who:    Richard Purdie <[email protected]>
+
+---------------------------
drivers/input/tsdev.c +4 -0
Index: linux/drivers/input/tsdev.c
===================================================================
@@ -151,6 +151,10 @@ static int tsdev_open(struct inode *inod
 	int i = iminor(inode) - TSDEV_MINOR_BASE;
 	struct tsdev_list *list;
 
+	printk(KERN_WARNING "tsdev (compaq touchscreen emulation) is scheduled "
+		"for removal.\nSee Documentation/feature-removal-schedule.txt "
+		"for details.\n");
+
 	if (i >= TSDEV_MINORS || !tsdev_table[i & TSDEV_MINOR_MASK])
 		return -ENODEV;
 
#4 lore raw
Quoted 5 lines · Richard Purdie
Quoted 1 line · Andrew Morton

On Tue, 06 Feb 2007 16:42:39 +0000 Richard Purdie <[email protected]> wrote:

drivers/input/tsdev.c static int tsdev_open(struct inode *inod · line 160

Quoted 10 lines
drivers/input/tsdev.c +4 -0
@@ -151,6 +151,10 @@ static int tsdev_open(struct inode *inod
 	int i = iminor(inode) - TSDEV_MINOR_BASE;
 	struct tsdev_list *list;
 
+	printk(KERN_WARNING "tsdev (compaq touchscreen emulation) is scheduled "
+		"for removal.\nSee Documentation/feature-removal-schedule.txt "
+		"for details.\n");
+
 	if (i >= TSDEV_MINORS || !tsdev_table[i & TSDEV_MINOR_MASK])
 		return -ENODEV;
 

What about a hugh annoying mdelay()?

MfG, JBG

Signature · 7 lines
      Jan-Benedict Glaw      [email protected]              +49-172-7608481
Signature of: 23:53 <@jbglaw> So, ich kletter' jetzt mal ins Bett.
the second  : 23:57 <@jever2> .oO( kletter ..., hat er noch Gitter vorm Bett, wie früher meine Kinder?)
              00:00 <@jbglaw> jever2: *patsch*
              00:01 <@jever2> *aua*, wofür, Gedanken sind frei!
              00:02 <@jbglaw> Nee, freie Gedanken, die sind seit 1984 doch aus!
              00:03 <@jever2> 1984? ich bin erst seit 1985 verheiratet!