Skip to contentSkip to conversation

Patch for enabling LFE on more Dell laptops

PATCH In review Mikael Nilsson 2 participants 5 messages Feb 13, 2007 – Feb 14, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Patch for enabling LFE on more Dell laptops

(please cc: me on replies, I'm not on the list)

Referring to

https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2092

I'd like to add this patch to the snd-hda-intel driver. The patch is against 1.0.14rc2.

Summary: Fix LFE controls for Dell Inspiron E1705/9400 and XPS M1710 laptops

patch_sigmatel.c 2007-02-13 11:51:25.000000000 +0100 renamed from patch_sigmatel.c.orig 2007-02-13 11:49:53.000000000 +0100 +4 -0
@@ -455,6 +455,10 @@
                      "Dell Latitude D620", STAC_REF),
        SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cb,
                      "Dell Latitude 120L", STAC_REF),
+       SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cd,
+                     "Dell Inspiron E1705/9400", STAC_REF),
+       SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01ce,
+                     "Dell XPS M1710", STAC_REF),
        {} /* terminator */
 };
 

Thanks,

/Mikael

Signature · 14 lines
<[email protected]>

Plus ça change, plus c'est la même chose


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel
#1 lore raw

At Tue, 13 Feb 2007 12:01:04 +0100,

Quoted 5 lines · Mikael Nilsson

(please cc: me on replies, I'm not on the list)

Referring to

Quoted 8 lines

https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2092

I'd like to add this patch to the snd-hda-intel driver. The patch is against 1.0.14rc2.

Summary: Fix LFE controls for Dell Inspiron E1705/9400 and XPS M1710 laptops

The patch couldn't be applied to the latest HG tree (or 2.6.21-git) but I fixed it manually. Also, the embedded patch in your mail seems broken. Check your MUA.

Anyway, the patch is applied to ALSA HG tree now. Thanks.

Takashi

Quoted 15 lines
patch_sigmatel.c 2007-02-13 11:51:25.000000000 +0100 renamed from patch_sigmatel.c.orig 2007-02-13 11:49:53.000000000 +0100 +4 -0
@@ -455,6 +455,10 @@
                      "Dell Latitude D620", STAC_REF),
        SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cb,
                      "Dell Latitude 120L", STAC_REF),
+       SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cd,
+                     "Dell Inspiron E1705/9400", STAC_REF),
+       SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01ce,
+                     "Dell XPS M1710", STAC_REF),
        {} /* terminator */
 };
 
Quoted 18 lines

Thanks,

/Mikael

Signature · 14 lines
<[email protected]>

Plus ça change, plus c'est la même chose


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

#2 lore raw
Quoted 12 lines · Takashi Iwai

At Tue, 13 Feb 2007 12:01:04 +0100,

Quoted 10 lines · Mikael Nilsson

(please cc: me on replies, I'm not on the list)

Referring to

https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2092

I'd like to add this patch to the snd-hda-intel driver. The patch is against 1.0.14rc2.

Quoted 7 lines
Quoted 3 lines

Summary: Fix LFE controls for Dell Inspiron E1705/9400 and XPS M1710 laptops

The patch couldn't be applied to the latest HG tree (or 2.6.21-git) but I fixed it manually. Also, the embedded patch in your mail seems broken. Check your MUA.

Duh... thanks in any case. The bugs

https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2092
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2170
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2580

can probably be closed by this patch.

/Mikael

Quoted 40 lines

Anyway, the patch is applied to ALSA HG tree now. Thanks.

Takashi

Quoted 33 lines
patch_sigmatel.c 2007-02-13 11:51:25.000000000 +0100 renamed from patch_sigmatel.c.orig 2007-02-13 11:49:53.000000000 +0100 +4 -0
@@ -455,6 +455,10 @@
                      "Dell Latitude D620", STAC_REF),
        SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cb,
                      "Dell Latitude 120L", STAC_REF),
+       SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cd,
+                     "Dell Inspiron E1705/9400", STAC_REF),
+       SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01ce,
+                     "Dell XPS M1710", STAC_REF),
        {} /* terminator */
 };
 

Thanks,

/Mikael

Signature · 14 lines
<[email protected]>

Plus ça change, plus c'est la même chose


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel
Signature · 14 lines
<[email protected]>

Plus ça change, plus c'est la même chose


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel
#3 lore raw
In reply to Takashi Iwai
Quoted 1 line · Takashi Iwai

Anyway, the patch is applied to ALSA HG tree now. Thanks.

While we're at it, please add the Precision M90 as well:

SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cf,
"Dell Precision M90", STAC_REF),

/Mikael

Quoted 39 lines

Takashi

Quoted 33 lines
patch_sigmatel.c 2007-02-13 11:51:25.000000000 +0100 renamed from patch_sigmatel.c.orig 2007-02-13 11:49:53.000000000 +0100 +4 -0
@@ -455,6 +455,10 @@
                      "Dell Latitude D620", STAC_REF),
        SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cb,
                      "Dell Latitude 120L", STAC_REF),
+       SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cd,
+                     "Dell Inspiron E1705/9400", STAC_REF),
+       SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01ce,
+                     "Dell XPS M1710", STAC_REF),
        {} /* terminator */
 };
 

Thanks,

/Mikael

Signature · 14 lines
<[email protected]>

Plus ça change, plus c'est la même chose


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel
Signature · 14 lines
<[email protected]>

Plus ça change, plus c'est la même chose


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel
#4 lore raw

At Tue, 13 Feb 2007 20:11:43 +0100,

Quoted 9 lines · Mikael Nilsson
Quoted 1 line · Takashi Iwai

Anyway, the patch is applied to ALSA HG tree now. Thanks.

While we're at it, please add the Precision M90 as well:

SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cf,
"Dell Precision M90", STAC_REF),

Added to HG tree. Thanks.

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV