Skip to contentSkip to conversation

powerpc: Make of_device_uevent() compatible with ibmebus

PATCH In review Hoang-Nam Nguyen 3 participants 6 messages Feb 17, 2007 – Feb 19, 2007 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: Make of_device_uevent() compatible with ibmebus

ibmebus has a fake root device that's not associated with an ofdt node. Filter out any such devices in of_device_uevent().

---

 of_device.c |    4 ++++
 1 files changed, 4 insertions(+)
arch/powerpc/kernel/of_device.c +4 -0
diff -urp a/arch/powerpc/kernel/of_device.c b/arch/powerpc/kernel/of_device.c
@@ -180,6 +180,10 @@ int of_device_uevent(struct device *dev,
 
 	ofdev = to_of_device(dev);
 
+	/* e.g. ibmebus has a fake root device w/o ofdt node -- filter that */
+	if (!ofdev->node)
+		return -ENODEV;
+
 	if (add_uevent_var(envp, num_envp, &i,
 			   buffer, buffer_size, &length,
 			   "OF_NAME=%s", ofdev->node->name))
#1 lore raw
Quoted 2 lines · Hoang-Nam Nguyen

ibmebus has a fake root device that's not associated with an ofdt node. Filter out any such devices in of_device_uevent().

Doh ! You are creating an of_device with no attached device-node ? That is totally evil ! Why do you need that ?

Ben.

Quoted 28 lines

---

 of_device.c |    4 ++++
 1 files changed, 4 insertions(+)

diff -urp a/arch/powerpc/kernel/of_device.c b/arch/powerpc/kernel/of_device.c

arch/powerpc/kernel/of_device.c +4 -0
@@ -180,6 +180,10 @@ int of_device_uevent(struct device *dev,
 
 	ofdev = to_of_device(dev);
 
+	/* e.g. ibmebus has a fake root device w/o ofdt node -- filter that */
+	if (!ofdev->node)
+		return -ENODEV;
+
 	if (add_uevent_var(envp, num_envp, &i,
 			   buffer, buffer_size, &length,
 			   "OF_NAME=%s", ofdev->node->name))

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev

#2 lore raw

Benjamin Herrenschmidt <[email protected]> wrote on 17.02.2007 16:56:39:

Quoted 2 lines · Hoang-Nam Nguyen
Quoted 1 line

ibmebus has a fake root device that's not associated with an ofdt

node.

Quoted 4 lines
Quoted 1 line

Filter out any such devices in of_device_uevent().

Doh ! You are creating an of_device with no attached device-node ? That is totally evil ! Why do you need that ?

The driver creates a fake "ibmebus" device so all ibmebus based devices have
a common parent device -- the vio bus does the same.

What do you think about linking this device to the device tree "/" node? All
ibmebus-based devices are linked to dt nodes residing directly beneath "/",
so the mapping would fit.

Cheers,
Joachim

---
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer extraordinaire
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Development
2)

Schoenaicher Strasse 220  --  71032 Boeblingen  --  Germany
eMail: [email protected]  --  Phone: +49 7031 16 1239 

Vorsitzender des Aufsichtsrats: Johann Weihen -- Geschäftsführung:
Herbert Kircher
Sitz der Gesellschaft: Böblingen -- Registergericht: Amtsgericht Stuttgart, HRB 243294

#3 lore raw
Quoted 15 lines · Joachim Fenkes

Benjamin Herrenschmidt <[email protected]> wrote on 17.02.2007 16:56:39:

Quoted 2 lines · Hoang-Nam Nguyen
Quoted 1 line

ibmebus has a fake root device that's not associated with an ofdt

node.

Quoted 4 lines
Quoted 1 line

Filter out any such devices in of_device_uevent().

Doh ! You are creating an of_device with no attached device-node ? That is totally evil ! Why do you need that ?

The driver creates a fake "ibmebus" device so all ibmebus based devices have
a common parent device -- the vio bus does the same.

Quoted 5 lines

What do you think about linking this device to the device tree "/" node? All
ibmebus-based devices are linked to dt nodes residing directly beneath "/",
so the mapping would fit.

No. If you do that, it shouldn't be an of_device based device.

If you want then to be below a common parent, then create that parent of a basic struct device type, that sort of thing. You should never instanciate an of_device that has a NULL device node.

vio is different since it's not a "subclass" of of_device though I tend to also disagree with the way it does things.

It's a generic problem with sysfs, I agree it somewhat sucks.

Ben.

#4 lore raw

Benjamin Herrenschmidt <[email protected]> wrote on 17.02.2007=20 19:37:25:

Quoted 1 line
Quoted 1 line
Quoted 1 line

Doh ! You are creating an of=5Fdevice with no attached device-node ? =

That

Quoted 3 lines
Quoted 3 lines
Quoted 1 line

is totally evil ! Why do you need that ?

=20
The driver creates a fake "ibmebus" device so all ibmebus based=20

devices=20

Quoted 4 lines
Quoted 4 lines

have
a common parent device -- the vio bus does the same.
=20
What do you think about linking this device to the device tree "/"=20

node?=20

Quoted 4 lines
Quoted 2 lines

All
ibmebus-based devices are linked to dt nodes residing directly beneath =

Quoted 8 lines
Quoted 2 lines

"/",
so the mapping would fit.

=20
No. If you do that, it shouldn't be an of=5Fdevice based device. =20
If you want then to be below a common parent, then create that parent of a basic struct device type, that sort of thing. You should never instanciate an of=5Fdevice that has a NULL device node.

If I make the root device a basic struct device, it can't be part of=20 ibmebus any
longer. If we could create a busless device, we wouldn't have a problem,=20 but I
doubt that is possible.

Do you have any creative ideas?
=20

Quoted 1 line

It's a generic problem with sysfs, I agree it somewhat sucks.

With ya.

Later,
Joachim

---
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer=20 extraordinaire
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Development =

2)

Schoenaicher Strasse 220  --  71032 Boeblingen  --  Germany
eMail: [email protected]  --  Phone: +49 7031 16 1239=20

Vorsitzender des Aufsichtsrats: Johann Weihen -- Gesch=E4ftsf=FChrung:=20 Herbert Kircher
Sitz der Gesellschaft: B=F6blingen -- Registergericht: Amtsgericht=20 Stuttgart, HRB 243294

#5 lore raw
Quoted 8 lines

If I make the root device a basic struct device, it can't be part of ibmebus any
longer. If we could create a busless device, we wouldn't have a problem, but I
doubt that is possible.

Do you have any creative ideas?

Well, I think PCI does just that for PCI busses ... (a busless device)

Ben.

Quoted 19 lines
Quoted 1 line

It's a generic problem with sysfs, I agree it somewhat sucks.

With ya.

Later,
Joachim

---
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer extraordinaire
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Development
2)

Schoenaicher Strasse 220  --  71032 Boeblingen  --  Germany
eMail: [email protected]  --  Phone: +49 7031 16 1239 

Vorsitzender des Aufsichtsrats: Johann Weihen -- Geschäftsführung:
Herbert Kircher
Sitz der Gesellschaft: Böblingen -- Registergericht: Amtsgericht Stuttgart, HRB 243294