Skip to contentSkip to conversation

is_power_of_2 in rtc

PATCH RESEND New Vignesh Babu BM 1 participant 1 message Feb 19, 2007

Subsystems (2)
Kernel janitors Real time clock (RTC)
lore
Share & tools
lore

Vignesh Babu BM

author
#0 lore raw

PATCH RESEND 1/1 is_power_of_2 in rtc

Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2...resent to fix a change in the logic

Signed-off-by vignesh babu <[email protected]>

---

drivers/rtc/rtc-s3c.c +2 -1
index f406a2b..212ec32 100644
@@ -20,6 +20,7 @@
 #include <linux/rtc.h>
 #include <linux/bcd.h>
 #include <linux/clk.h>
+#include <linux/log2.h>
 
 #include <asm/hardware.h>
 #include <asm/uaccess.h>

@@ -311,7 +312,7 @@ static int s3c_rtc_ioctl(struct device *dev,
 	case RTC_IRQP_SET:
 		/* check for power of 2 */
 
-		if ((arg & (arg-1)) != 0 || arg < 1) {
+		if (!is_power_of_2(arg)) {
 			ret = -EINVAL;
 			goto exit;
 		}

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors