: Error handling in max17042_battery.c
Sender : Pallala, Ramakrishna<[email protected]> Date : 2011-08-26 14:46 (GMT+09:00)
Quoted 11 lines
Hi All,
I am working on the I2C based max17042 fuel gauge driver Which is
drivers/power/max17042_battery.cIn
max17042_get_property(...), the values returned byMax17042_read_regare directly assigned to the variables, even if the read results in an error. Shouldn't we check for the 'correctness' of the returned values and then assign them ? Can I submit a patch to change this ?
Quoted 5 lines
Or Is this done intentionally ?
Thanks,
Ram
Hello,
I did not ignore and return the error values from max17042_read_reg() intentionally, I've just missed them somehow (maybe was too lazy that day?).
Handling errors from max17042_read_reg() at the side of max17042_get_property() is a feature missing. And, I'd be much appreciated if you'd send the patch you've mentioned.
Thank you, MyungJoo�淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay� ���,j�f＂톒쉹��묎�z_溫(�쉸듶줷"얎�m����G쳺�◀?솳鈺�&ｘ�~뤳턨O뺞촾퇉v�^�m��� �띠�◀?뻀�