Skip to contentSkip to conversation

Make save/restore of multiple VCPU contexts arch dependent

PATCH In review Alex Williamson 2 participants 3 messages Mar 5, 2007 – Mar 8, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Make save/restore of multiple VCPU contexts arch dependent

We need to look at how to support this on ia64, so how about making
this an architecture dependent feature for now? Not sure what powerpc needs here, so I'm just lumping it into the old way bucket. Thanks,

Alex

---

tools/python/xen/xend/XendDomainInfo.py +6 -1
diff -r 3ac19fda0bc2 tools/python/xen/xend/XendDomainInfo.py
@@ -775,13 +775,18 @@ class XendDomainInfo:
         t.write('vm', self.vmpath)
 
     def _storeDomDetails(self):
+        if arch.type == "x86":
+            mp_suspend = 1
+        else:
+            mp_suspend = 0
+
         to_store = {
             'domid':              str(self.domid),
             'vm':                 self.vmpath,
             'name':               self.info['name_label'],
             'console/limit':      str(xoptions.get_console_limit() * 1024),
             'memory/target':      str(self.info['memory_static_min'] * 1024),
-            'control/platform-feature-multiprocessor-suspend': str(1)
+            'control/platform-feature-multiprocessor-suspend': str(mp_suspend)
             }
 
         def f(n, v):
#1 lore raw
Quoted 3 lines · Alex Williamson

We need to look at how to support this on ia64, so how about making
this an architecture dependent feature for now? Not sure what powerpc needs here, so I'm just lumping it into the old way bucket. Thanks,

Keir,

Did you have any objections or comments about this patch? Thanks,

Alex

Quoted 24 lines

diff -r 3ac19fda0bc2 tools/python/xen/xend/XendDomainInfo.py

tools/python/xen/xend/XendDomainInfo.py +6 -1
@@ -775,13 +775,18 @@ class XendDomainInfo:
         t.write('vm', self.vmpath)
 
     def _storeDomDetails(self):
+        if arch.type == "x86":
+            mp_suspend = 1
+        else:
+            mp_suspend = 0
+
         to_store = {
             'domid':              str(self.domid),
             'vm':                 self.vmpath,
             'name':               self.info['name_label'],
             'console/limit':      str(xoptions.get_console_limit() * 1024),
             'memory/target':      str(self.info['memory_static_min'] * 1024),
-            'control/platform-feature-multiprocessor-suspend': str(1)
+            'control/platform-feature-multiprocessor-suspend': str(mp_suspend)
             }
 
         def f(n, v):
Signature · 1 line
Alex Williamson                             HP Open Source & Linux Org.
#2 lore raw
Quoted 8 lines · Alex Williamson
Quoted 3 lines · Alex Williamson

We need to look at how to support this on ia64, so how about making
this an architecture dependent feature for now? Not sure what powerpc needs here, so I'm just lumping it into the old way bucket. Thanks,

Keir,

Did you have any objections or comments about this patch? Thanks,

I think I missed the original email somehow. Yes, this patch looks fine. I'll check it in.

-- Keir